[PATCH v4 0/2] hw/ssi/pnv_spi: Remove PnvXferBuffer and fix CID 1558827

Chalapathi V posted 2 patches 1 week, 4 days ago
include/hw/ssi/pnv_spi.h |   3 +
hw/ssi/pnv_spi.c         | 320 +++++++++++++++------------------------
2 files changed, 124 insertions(+), 199 deletions(-)
[PATCH v4 0/2] hw/ssi/pnv_spi: Remove PnvXferBuffer and fix CID 1558827
Posted by Chalapathi V 1 week, 4 days ago
Hello,

Thank You for reviewing patch v3, patch v4 addresses Nick's comments to
use fifo8_num_used() and open-code next_sequencer_fsm().

Updates in V4:
1. Use of PnvXferBuffer results in a additonal process overhead due to
frequent dynamic allocations and hence use an existing Fifo8 buffer.
2. Use a local variable seq_index and use it with in while loop instead
of repeatedly calling get_seq_index() and make sure s->seq_op doesn't
overrun when seq_index is incremented.

Tested:
passed make check and make check-avocado

Chalapathi V (2):
  hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure
  hw/ssi/pnv_spi: Coverity CID 1558827: Use local var seq_index instead
    of get_seq_index().

 include/hw/ssi/pnv_spi.h |   3 +
 hw/ssi/pnv_spi.c         | 320 +++++++++++++++------------------------
 2 files changed, 124 insertions(+), 199 deletions(-)

-- 
2.39.5