target/arm: Drop user-only special case in sve_stN_r

[PATCH for-9.2] target/arm: Drop user-only special case in sve_stN_r

Posted by Richard Henderson 1 week, 4 days ago

This path is reachable with plugins enabled, and provoked
with run-plugin-catch-syscalls-with-libinline.so.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/tcg/sve_helper.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c
index f1ee0e060f..904296705c 100644
--- a/target/arm/tcg/sve_helper.c
+++ b/target/arm/tcg/sve_helper.c
@@ -6317,9 +6317,6 @@ void sve_stN_r(CPUARMState *env, uint64_t *vg, target_ulong addr,
 
     flags = info.page[0].flags | info.page[1].flags;
     if (unlikely(flags != 0)) {
-#ifdef CONFIG_USER_ONLY
-        g_assert_not_reached();
-#else
         /*
          * At least one page includes MMIO.
          * Any bus operation can fail with cpu_transaction_failed,
@@ -6350,7 +6347,6 @@ void sve_stN_r(CPUARMState *env, uint64_t *vg, target_ulong addr,
             } while (reg_off & 63);
         } while (reg_off <= reg_last);
         return;
-#endif
     }
 
     mem_off = info.mem_off_first[0];
-- 
2.43.0

Re: [PATCH for-9.2] target/arm: Drop user-only special case in sve_stN_r

Posted by Peter Maydell 1 week, 2 days ago

On Tue, 12 Nov 2024 at 14:13, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This path is reachable with plugins enabled, and provoked
> with run-plugin-catch-syscalls-with-libinline.so.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/tcg/sve_helper.c | 4 ----
>  1 file changed, 4 deletions(-)

Applied to target-arm.next, thanks.

This looked like stable material to me so I've added the
cc-stable tag; let me know if you think that's not
appropriate.

-- PMM

Re: [PATCH for-9.2] target/arm: Drop user-only special case in sve_stN_r

Posted by Richard Henderson 1 week, 2 days ago

On 11/14/24 04:24, Peter Maydell wrote:
> On Tue, 12 Nov 2024 at 14:13, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> This path is reachable with plugins enabled, and provoked
>> with run-plugin-catch-syscalls-with-libinline.so.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   target/arm/tcg/sve_helper.c | 4 ----
>>   1 file changed, 4 deletions(-)
> 
> 
> Applied to target-arm.next, thanks.
> 
> This looked like stable material to me so I've added the
> cc-stable tag; let me know if you think that's not
> appropriate.

It does seem good for stable.

r~