[PATCH] docs/nitro-enclave: Fix terminal commands formatting

Dorjoy Chowdhury posted 1 patch 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20241109122844.24057-1-dorjoychy111@gmail.com
Maintainers: Alexander Graf <graf@amazon.com>, Dorjoy Chowdhury <dorjoychy111@gmail.com>
docs/system/i386/nitro-enclave.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH] docs/nitro-enclave: Fix terminal commands formatting
Posted by Dorjoy Chowdhury 1 year, 3 months ago
Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
---
 docs/system/i386/nitro-enclave.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/system/i386/nitro-enclave.rst b/docs/system/i386/nitro-enclave.rst
index 73e3edefe5..48eda5bd9e 100644
--- a/docs/system/i386/nitro-enclave.rst
+++ b/docs/system/i386/nitro-enclave.rst
@@ -48,13 +48,13 @@ Running a nitro-enclave VM
 First, run `vhost-device-vsock`__ (or a similar tool that supports vhost-user-vsock).
 The forward-cid option below with value 1 forwards all connections from the enclave
 VM to the host machine and the forward-listen (port numbers separated by '+') is used
-for forwarding connections from the host machine to the enclave VM.
-
-__ https://github.com/rust-vmm/vhost-device/tree/main/vhost-device-vsock#using-the-vsock-backend
+for forwarding connections from the host machine to the enclave VM::
 
   $ vhost-device-vsock \
      --vm guest-cid=4,forward-cid=1,forward-listen=9001+9002,socket=/tmp/vhost4.socket
 
+__ https://github.com/rust-vmm/vhost-device/tree/main/vhost-device-vsock#using-the-vsock-backend
+
 Now run the necessary applications on the host machine so that the nitro-enclave VM
 applications' vsock communication works. For example, the nitro-enclave VM's init
 process connects to CID 3 and sends a single byte hello heartbeat (0xB7) to let the
@@ -65,7 +65,7 @@ the applications on the host machine that would typically be running in the pare
 VM for successful communication with the enclave VM.
 
 Then run the nitro-enclave VM using the following command where ``hello.eif`` is
-an EIF file you would use to spawn a real AWS nitro enclave virtual machine:
+an EIF file you would use to spawn a real AWS nitro enclave virtual machine::
 
   $ qemu-system-x86_64 -M nitro-enclave,vsock=c,id=hello-world \
      -kernel hello-world.eif -nographic -m 4G --enable-kvm -cpu host \
-- 
2.39.5
Re: [PATCH] docs/nitro-enclave: Fix terminal commands formatting
Posted by Philippe Mathieu-Daudé 1 year, 1 month ago
On 9/11/24 13:28, Dorjoy Chowdhury wrote:
> Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
> ---
>   docs/system/i386/nitro-enclave.rst | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Queued, thanks!
Re: [PATCH] docs/nitro-enclave: Fix terminal commands formatting
Posted by Alexander Graf 1 year, 2 months ago
On 09.11.24 13:28, Dorjoy Chowdhury wrote:
>
> Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>


(nit: Please make sure to always have a patch description in the body of 
the patch, even if it feels like the subject says it all)

Reviewed-by: Alexander Graf <graf@amazon.com>

Alex





Amazon Web Services Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597
Re: [PATCH] docs/nitro-enclave: Fix terminal commands formatting
Posted by Dorjoy Chowdhury 1 year, 2 months ago
On Mon, Dec 2, 2024 at 9:36 PM Alexander Graf <graf@amazon.com> wrote:
>
>
> On 09.11.24 13:28, Dorjoy Chowdhury wrote:
> >
> > Signed-off-by: Dorjoy Chowdhury <dorjoychy111@gmail.com>
>
>
> (nit: Please make sure to always have a patch description in the body of
> the patch, even if it feels like the subject says it all)
>
> Reviewed-by: Alexander Graf <graf@amazon.com>
>

cc Paolo. This has been reviewed so can be picked up for merging.

Regards,
Dorjoy
Re: [PATCH] docs/nitro-enclave: Fix terminal commands formatting
Posted by Dorjoy Chowdhury 1 year, 2 months ago
Ping.

Regards,
Dorjoy
Re: [PATCH] docs/nitro-enclave: Fix terminal commands formatting
Posted by Dorjoy Chowdhury 1 year, 2 months ago
On Mon, Nov 18, 2024 at 7:10 PM Dorjoy Chowdhury <dorjoychy111@gmail.com> wrote:
>
> Ping.
>

Ping...

This is a very small one that should fix the UI issue in
https://www.qemu.org/docs/master/system/i386/nitro-enclave.html . It
would be great if it could be reviewed and picked up for merging.
Thanks!

Regards,
Dorjoy
Re: [PATCH] docs/nitro-enclave: Fix terminal commands formatting
Posted by Dorjoy Chowdhury 1 year, 2 months ago
On Mon, Nov 25, 2024 at 8:59 PM Dorjoy Chowdhury <dorjoychy111@gmail.com> wrote:
>
> On Mon, Nov 18, 2024 at 7:10 PM Dorjoy Chowdhury <dorjoychy111@gmail.com> wrote:
> >
> > Ping.
> >
>
> Ping...
>
> This is a very small one that should fix the UI issue in
> https://www.qemu.org/docs/master/system/i386/nitro-enclave.html . It
> would be great if it could be reviewed and picked up for merging.
> Thanks!
>

Gentle ping.

Regards,
Dorjoy