1. Patchew
  2. QEMU
  3. View series

[PATCH v5 00/11] i386: miscellaneous cleanup

Zhao Liu posted 11 patches 1 year, 3 months ago
Failed in applying to current master (apply log)
hw/i386/kvm/clock.c              |   5 +-
target/i386/confidential-guest.h |   2 +-
target/i386/cpu.c                |   6 +-
target/i386/cpu.h                |  25 ++++
target/i386/kvm/kvm.c            | 211 +++++++++++++++++--------------
5 files changed, 145 insertions(+), 104 deletions(-)
[PATCH v5 00/11] i386: miscellaneous cleanup
Posted by Zhao Liu 1 year, 3 months ago 
Hi Paolo and all,

Is it necessary to include the first patch (AVX10 cleanup/fix) in v9.2?

Others are for v10.0.

Compared with v4 [1],
 * patch 1 (AVX10 fix) and patch 9 (RAPL cleanup) are newly added.
 * rebased on commit 9a7b0a8618b1 ("Merge tag 'pull-aspeed-20241104' of
   https://github.com/legoater/qemu into staging").


Background and Introduction
===========================

This series picks cleanup from my previous kvmclock [2] (as other
renaming attempts were temporarily put on hold).

In addition, this series also include the cleanup on a historically
workaround, recent comment of coco interface [3] and error handling
corner cases in kvm_arch_init().

Avoiding the fragmentation of these misc cleanups, I consolidated them
all in one series and was able to tackle them in one go!

[1]: https://lore.kernel.org/qemu-devel/20240716161015.263031-1-zhao1.liu@intel.com/
[2]: https://lore.kernel.org/qemu-devel/20240329101954.3954987-1-zhao1.liu@linux.intel.com/
[3]: https://lore.kernel.org/qemu-devel/2815f0f1-9e20-4985-849c-d74c6cdc94ae@intel.com/

Thanks and Best Regards,
Zhao
---
Zhao Liu (11):
  i386/cpu: Mark avx10_version filtered when prefix is NULL
  target/i386/kvm: Add feature bit definitions for KVM CPUID
  target/i386/kvm: Remove local MSR_KVM_WALL_CLOCK and
    MSR_KVM_SYSTEM_TIME definitions
  target/i386/kvm: Only save/load kvmclock MSRs when kvmclock enabled
  target/i386/kvm: Save/load MSRs of kvmclock2
    (KVM_FEATURE_CLOCKSOURCE2)
  target/i386/kvm: Drop workaround for KVM_X86_DISABLE_EXITS_HTL typo
  target/i386/confidential-guest: Fix comment of
    x86_confidential_guest_kvm_type()
  target/i386/kvm: Clean up return values of MSR filter related
    functions
  target/i386/kvm: Return -1 when kvm_msr_energy_thread_init() fails
  target/i386/kvm: Clean up error handling in kvm_arch_init()
  target/i386/kvm: Replace ARRAY_SIZE(msr_handlers) with
    KVM_MSR_FILTER_MAX_RANGES

 hw/i386/kvm/clock.c              |   5 +-
 target/i386/confidential-guest.h |   2 +-
 target/i386/cpu.c                |   6 +-
 target/i386/cpu.h                |  25 ++++
 target/i386/kvm/kvm.c            | 211 +++++++++++++++++--------------
 5 files changed, 145 insertions(+), 104 deletions(-)

-- 
2.34.1
Re: [PATCH v5 00/11] i386: miscellaneous cleanup
Posted by Paolo Bonzini 1 year, 1 month ago 
On 11/6/24 04:07, Zhao Liu wrote:
> Hi Paolo and all,
> 
> Is it necessary to include the first patch (AVX10 cleanup/fix) in v9.2?
> 
> Others are for v10.0.
> 
> Compared with v4 [1],
>   * patch 1 (AVX10 fix) and patch 9 (RAPL cleanup) are newly added.
>   * rebased on commit 9a7b0a8618b1 ("Merge tag 'pull-aspeed-20241104' of
>     https://github.com/legoater/qemu into staging").

Removed patches 5 and 11, fixed patch 4 to include CPUID_KVM_CLOCK2, and 
queued - thanks!

Paolo

> 
> Background and Introduction
> ===========================
> 
> This series picks cleanup from my previous kvmclock [2] (as other
> renaming attempts were temporarily put on hold).
> 
> In addition, this series also include the cleanup on a historically
> workaround, recent comment of coco interface [3] and error handling
> corner cases in kvm_arch_init().
> 
> Avoiding the fragmentation of these misc cleanups, I consolidated them
> all in one series and was able to tackle them in one go!
> 
> [1]: https://lore.kernel.org/qemu-devel/20240716161015.263031-1-zhao1.liu@intel.com/
> [2]: https://lore.kernel.org/qemu-devel/20240329101954.3954987-1-zhao1.liu@linux.intel.com/
> [3]: https://lore.kernel.org/qemu-devel/2815f0f1-9e20-4985-849c-d74c6cdc94ae@intel.com/
> 
> Thanks and Best Regards,
> Zhao
> ---
> Zhao Liu (11):
>    i386/cpu: Mark avx10_version filtered when prefix is NULL
>    target/i386/kvm: Add feature bit definitions for KVM CPUID
>    target/i386/kvm: Remove local MSR_KVM_WALL_CLOCK and
>      MSR_KVM_SYSTEM_TIME definitions
>    target/i386/kvm: Only save/load kvmclock MSRs when kvmclock enabled
>    target/i386/kvm: Save/load MSRs of kvmclock2
>      (KVM_FEATURE_CLOCKSOURCE2)
>    target/i386/kvm: Drop workaround for KVM_X86_DISABLE_EXITS_HTL typo
>    target/i386/confidential-guest: Fix comment of
>      x86_confidential_guest_kvm_type()
>    target/i386/kvm: Clean up return values of MSR filter related
>      functions
>    target/i386/kvm: Return -1 when kvm_msr_energy_thread_init() fails
>    target/i386/kvm: Clean up error handling in kvm_arch_init()
>    target/i386/kvm: Replace ARRAY_SIZE(msr_handlers) with
>      KVM_MSR_FILTER_MAX_RANGES
> 
>   hw/i386/kvm/clock.c              |   5 +-
>   target/i386/confidential-guest.h |   2 +-
>   target/i386/cpu.c                |   6 +-
>   target/i386/cpu.h                |  25 ++++
>   target/i386/kvm/kvm.c            | 211 +++++++++++++++++--------------
>   5 files changed, 145 insertions(+), 104 deletions(-)
>
Re: [PATCH v5 00/11] i386: miscellaneous cleanup
Posted by Zhao Liu 1 year, 1 month ago 
Hi Paolo,

A kindly ping.

Thanks,
Zhao

On Wed, Nov 06, 2024 at 11:07:17AM +0800, Zhao Liu wrote:
> Date: Wed, 6 Nov 2024 11:07:17 +0800
> From: Zhao Liu <zhao1.liu@intel.com>
> Subject: [PATCH v5 00/11] i386: miscellaneous cleanup
> X-Mailer: git-send-email 2.34.1
> 
> Hi Paolo and all,
> 
> Is it necessary to include the first patch (AVX10 cleanup/fix) in v9.2?
> 
> Others are for v10.0.
> 
> Compared with v4 [1],
>  * patch 1 (AVX10 fix) and patch 9 (RAPL cleanup) are newly added.
>  * rebased on commit 9a7b0a8618b1 ("Merge tag 'pull-aspeed-20241104' of
>    https://github.com/legoater/qemu into staging").
> 
> 
> Background and Introduction
> ===========================
> 
> This series picks cleanup from my previous kvmclock [2] (as other
> renaming attempts were temporarily put on hold).
> 
> In addition, this series also include the cleanup on a historically
> workaround, recent comment of coco interface [3] and error handling
> corner cases in kvm_arch_init().
> 
> Avoiding the fragmentation of these misc cleanups, I consolidated them
> all in one series and was able to tackle them in one go!
> 
> [1]: https://lore.kernel.org/qemu-devel/20240716161015.263031-1-zhao1.liu@intel.com/
> [2]: https://lore.kernel.org/qemu-devel/20240329101954.3954987-1-zhao1.liu@linux.intel.com/
> [3]: https://lore.kernel.org/qemu-devel/2815f0f1-9e20-4985-849c-d74c6cdc94ae@intel.com/
> 
> Thanks and Best Regards,
> Zhao
> ---
> Zhao Liu (11):
>   i386/cpu: Mark avx10_version filtered when prefix is NULL
>   target/i386/kvm: Add feature bit definitions for KVM CPUID
>   target/i386/kvm: Remove local MSR_KVM_WALL_CLOCK and
>     MSR_KVM_SYSTEM_TIME definitions
>   target/i386/kvm: Only save/load kvmclock MSRs when kvmclock enabled
>   target/i386/kvm: Save/load MSRs of kvmclock2
>     (KVM_FEATURE_CLOCKSOURCE2)
>   target/i386/kvm: Drop workaround for KVM_X86_DISABLE_EXITS_HTL typo
>   target/i386/confidential-guest: Fix comment of
>     x86_confidential_guest_kvm_type()
>   target/i386/kvm: Clean up return values of MSR filter related
>     functions
>   target/i386/kvm: Return -1 when kvm_msr_energy_thread_init() fails
>   target/i386/kvm: Clean up error handling in kvm_arch_init()
>   target/i386/kvm: Replace ARRAY_SIZE(msr_handlers) with
>     KVM_MSR_FILTER_MAX_RANGES
> 
>  hw/i386/kvm/clock.c              |   5 +-
>  target/i386/confidential-guest.h |   2 +-
>  target/i386/cpu.c                |   6 +-
>  target/i386/cpu.h                |  25 ++++
>  target/i386/kvm/kvm.c            | 211 +++++++++++++++++--------------
>  5 files changed, 145 insertions(+), 104 deletions(-)
> 
> -- 
> 2.34.1
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.