[PATCH 5/5] i386/hvf: Removes duplicate/shadowed variables in hvf_vcpu_exec

Phil Dennis-Jordan posted 5 patches 2 weeks, 4 days ago
[PATCH 5/5] i386/hvf: Removes duplicate/shadowed variables in hvf_vcpu_exec
Posted by Phil Dennis-Jordan 2 weeks, 4 days ago
Pointers to the x86 CPU state already exist at the function scope,
no need to re-obtain them in individual exit reason cases.

Signed-off-by: Phil Dennis-Jordan <phil@philjordan.eu>
---
 target/i386/hvf/hvf.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index 8527bce6eef..c5d025d5576 100644
--- a/target/i386/hvf/hvf.c
+++ b/target/i386/hvf/hvf.c
@@ -586,8 +586,6 @@ int hvf_vcpu_exec(CPUState *cpu)
             break;
         }
         case EXIT_REASON_XSETBV: {
-            X86CPU *x86_cpu = X86_CPU(cpu);
-            CPUX86State *env = &x86_cpu->env;
             uint32_t eax = (uint32_t)rreg(cpu->accel->fd, HV_X86_RAX);
             uint32_t ecx = (uint32_t)rreg(cpu->accel->fd, HV_X86_RCX);
             uint32_t edx = (uint32_t)rreg(cpu->accel->fd, HV_X86_RDX);
@@ -644,7 +642,6 @@ int hvf_vcpu_exec(CPUState *cpu)
                 break;
             }
             case 8: {
-                X86CPU *x86_cpu = X86_CPU(cpu);
                 if (exit_qual & 0x10) {
                     RRX(env, reg) = cpu_get_apic_tpr(x86_cpu->apic_state);
                 } else {
-- 
2.39.3 (Apple Git-145)
Re: [PATCH 5/5] i386/hvf: Removes duplicate/shadowed variables in hvf_vcpu_exec
Posted by Roman Bolshakov 2 weeks, 3 days ago
On Tue, Nov 05, 2024 at 04:58:00PM +0100, Phil Dennis-Jordan wrote:
> Pointers to the x86 CPU state already exist at the function scope,
> no need to re-obtain them in individual exit reason cases.
> 

Reviewed-by: Roman Bolshakov <rbolshakov@ddn.com>

Regards,
Roman