[v1] chardev/char-mux: tweak mux bitset operations

[PATCH 0/2] chardev/char-mux: tweak mux bitset operations

Posted by Roman Penyaev 3 weeks ago

Patchset tweaks bitset operations by changing a constant to unsigned
long, introduces a static compile check and simplifies bitset operations.

Roman Penyaev (2):
  chardev/char-mux: shift unsigned long to avoid 32-bit overflow
  chardev/char-mux: make boolean bit check instead of find_next_bit()

 chardev/char-mux.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
Cc: qemu-devel@nongnu.org

-- 
2.34.1

Re: [PATCH 0/2] chardev/char-mux: tweak mux bitset operations

Posted by CLEMENT MATHIEU--DRIF 2 weeks, 5 days ago

Hi Roman,

Reviewed-by Clément Mathieu--Drif <clement.mathieu--drif@eviden.com><mailto:clement.mathieu--drif@eviden.com> Thanks!

On 02/11/2024 12:07, Roman Penyaev wrote:

Caution: External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe.


Patchset tweaks bitset operations by changing a constant to unsigned
long, introduces a static compile check and simplifies bitset operations.

Roman Penyaev (2):
  chardev/char-mux: shift unsigned long to avoid 32-bit overflow
  chardev/char-mux: make boolean bit check instead of find_next_bit()

 chardev/char-mux.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Signed-off-by: Roman Penyaev <r.peniaev@gmail.com><mailto:r.peniaev@gmail.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com><mailto:marcandre.lureau@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org><mailto:peter.maydell@linaro.org>
Cc: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com><mailto:clement.mathieu--drif@eviden.com>
Cc: qemu-devel@nongnu.org<mailto:qemu-devel@nongnu.org>

--
2.34.1

Re: [PATCH 0/2] chardev/char-mux: tweak mux bitset operations

Posted by Marc-André Lureau 2 weeks, 5 days ago

Hi

On Sat, Nov 2, 2024 at 3:11 PM Roman Penyaev <r.peniaev@gmail.com> wrote:

> Patchset tweaks bitset operations by changing a constant to unsigned
> long, introduces a static compile check and simplifies bitset operations.
>
> Roman Penyaev (2):
>   chardev/char-mux: shift unsigned long to avoid 32-bit overflow
>   chardev/char-mux: make boolean bit check instead of find_next_bit()
>
>  chardev/char-mux.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
>
> Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
> Cc: qemu-devel@nongnu.org


Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


-- 
Marc-André Lureau