tests/tcg: Replace -mpower8-vector with -mcpu=power8

[PATCH v2] tests/tcg: Replace -mpower8-vector with -mcpu=power8

Posted by Ilya Leoshkevich 1 year, 3 months ago

[1] deprecated -mpower8-vector, resulting in:

    powerpc64-linux-gnu-gcc: warning: switch '-mpower8-vector' is no longer supported
    qemu/tests/tcg/ppc64/vsx_f2i_nan.c:4:15: error: expected ';' before 'float'
        4 | typedef vector float vsx_float32_vec_t;
          |               ^~~~~~

Use -mcpu=power8 instead. In order to properly verify that this works,
one needs a big-endian (the minimum supported CPU for 64-bit
little-endian is power8 anyway) GCC configured with --enable-checking
(see GCC commit e154242724b0 ("[RS6000] Don't pass -many to the
assembler").

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109987

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
v1: https://lore.kernel.org/qemu-devel/20241021142830.486149-1-iii@linux.ibm.com/
v1 -> v2: Use -mcpu=power8 instead of -mvsx (Richard).

 tests/tcg/ppc64/Makefile.target | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/tcg/ppc64/Makefile.target b/tests/tcg/ppc64/Makefile.target
index 1940886c737..0d058b26006 100644
--- a/tests/tcg/ppc64/Makefile.target
+++ b/tests/tcg/ppc64/Makefile.target
@@ -6,7 +6,7 @@ VPATH += $(SRC_PATH)/tests/tcg/ppc64
 
 config-cc.mak: Makefile
 	$(quiet-@)( \
-	    $(call cc-option,-mpower8-vector,   CROSS_CC_HAS_POWER8_VECTOR); \
+	    $(call cc-option,-mcpu=power8,      CROSS_CC_HAS_CPU_POWER8); \
 	    $(call cc-option,-mpower10,         CROSS_CC_HAS_POWER10)) 3> config-cc.mak
 
 -include config-cc.mak
@@ -23,15 +23,15 @@ run-threadcount: threadcount
 run-plugin-threadcount-with-%:
 	$(call skip-test, $<, "BROKEN (flaky with clang) ")
 
-ifneq ($(CROSS_CC_HAS_POWER8_VECTOR),)
+ifneq ($(CROSS_CC_HAS_CPU_POWER8),)
 PPC64_TESTS=bcdsub non_signalling_xscv
 endif
-$(PPC64_TESTS): CFLAGS += -mpower8-vector
+$(PPC64_TESTS): CFLAGS += -mcpu=power8
 
-ifneq ($(CROSS_CC_HAS_POWER8_VECTOR),)
+ifneq ($(CROSS_CC_HAS_CPU_POWER8),)
 PPC64_TESTS += vsx_f2i_nan
 endif
-vsx_f2i_nan: CFLAGS += -mpower8-vector -I$(SRC_PATH)/include
+vsx_f2i_nan: CFLAGS += -mcpu=power8 -I$(SRC_PATH)/include
 
 PPC64_TESTS += mtfsf
 PPC64_TESTS += mffsce
-- 
2.47.0

Re: [PATCH v2] tests/tcg: Replace -mpower8-vector with -mcpu=power8

Posted by Alex Bennée 1 year, 3 months ago

Ilya Leoshkevich <iii@linux.ibm.com> writes:

> [1] deprecated -mpower8-vector, resulting in:
>
>     powerpc64-linux-gnu-gcc: warning: switch '-mpower8-vector' is no longer supported
>     qemu/tests/tcg/ppc64/vsx_f2i_nan.c:4:15: error: expected ';' before 'float'
>         4 | typedef vector float vsx_float32_vec_t;
>           |               ^~~~~~
>
> Use -mcpu=power8 instead. In order to properly verify that this works,
> one needs a big-endian (the minimum supported CPU for 64-bit
> little-endian is power8 anyway) GCC configured with --enable-checking
> (see GCC commit e154242724b0 ("[RS6000] Don't pass -many to the
> assembler").
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109987
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] tests/tcg: Replace -mpower8-vector with -mcpu=power8

Posted by Richard Henderson 1 year, 3 months ago

On 10/23/24 06:12, Ilya Leoshkevich wrote:
> [1] deprecated -mpower8-vector, resulting in:
> 
>      powerpc64-linux-gnu-gcc: warning: switch '-mpower8-vector' is no longer supported
>      qemu/tests/tcg/ppc64/vsx_f2i_nan.c:4:15: error: expected ';' before 'float'
>          4 | typedef vector float vsx_float32_vec_t;
>            |               ^~~~~~
> 
> Use -mcpu=power8 instead. In order to properly verify that this works,
> one needs a big-endian (the minimum supported CPU for 64-bit
> little-endian is power8 anyway) GCC configured with --enable-checking
> (see GCC commit e154242724b0 ("[RS6000] Don't pass -many to the
> assembler").
> 
> [1]https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109987
> 
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
> v1:https://lore.kernel.org/qemu-devel/20241021142830.486149-1-iii@linux.ibm.com/
> v1 -> v2: Use -mcpu=power8 instead of -mvsx (Richard).
> 
>   tests/tcg/ppc64/Makefile.target | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~