next-cube: more tidy-ups and improvements

[PATCH 02/36] next-cube: remove 0x14020 dummy value from next_mmio_read()

Posted by Mark Cave-Ayland 1 month ago

This is a dummy value for the SCSI CSR which appears to have no effect when
removed. Eventually the reads/writes to this register will be directed
towards the WIP implementations in next_scr_readfn() and next_scr_writefn().

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/m68k/next-cube.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index 7a503e0707..4e8e55a8bd 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -286,10 +286,6 @@ static uint64_t next_mmio_read(void *opaque, hwaddr addr, unsigned size)
                         size << 3);
         break;
 
-    case 0x14020:
-        val = 0x7f;
-        break;
-
     default:
         val = 0;
         DPRINTF("MMIO Read @ 0x%"HWADDR_PRIx" size %d\n", addr, size);
-- 
2.39.5

Re: [PATCH 02/36] next-cube: remove 0x14020 dummy value from next_mmio_read()

Posted by Thomas Huth 4 weeks ago

Am Wed, 23 Oct 2024 09:58:18 +0100
schrieb Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>:

> This is a dummy value for the SCSI CSR which appears to have no effect when
> removed. Eventually the reads/writes to this register will be directed
> towards the WIP implementations in next_scr_readfn() and next_scr_writefn().
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/m68k/next-cube.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Thomas Huth <huth@tuxfamily.org>