1. Patchew
  2. QEMU
  3. View series

[PATCH] gitlab: enable afalg tests in fedora system test

Daniel P. Berrangé posted 1 patch 1 day, 3 hours ago 
.gitlab-ci.d/buildtest.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] gitlab: enable afalg tests in fedora system test
Posted by Daniel P. Berrangé 1 day, 3 hours ago 
The AF_ALG crypto integration for Linux is not being tested in
any CI scenario. It always requires an explicit configure time
flag to be passed to turn it on. The Fedora system test is
arbitrarily picked as the place to test it.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .gitlab-ci.d/buildtest.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This is to detect the situation Markus found here:

  https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 01e8470a69..f0cbdf1992 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -115,7 +115,7 @@ build-system-fedora:
     job: amd64-fedora-container
   variables:
     IMAGE: fedora
-    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
+    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
     TARGETS: microblaze-softmmu mips-softmmu
       xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
     MAKE_CHECK_ARGS: check-build
-- 
2.46.0
Re: [PATCH] gitlab: enable afalg tests in fedora system test
Posted by Cédric Le Goater 4 hours ago 
On 10/21/24 19:02, Daniel P. Berrangé wrote:
> The AF_ALG crypto integration for Linux is not being tested in
> any CI scenario. It always requires an explicit configure time
> flag to be passed to turn it on. The Fedora system test is
> arbitrarily picked as the place to test it.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   .gitlab-ci.d/buildtest.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This is to detect the situation Markus found here:
> 
>    https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
> 
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index 01e8470a69..f0cbdf1992 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -115,7 +115,7 @@ build-system-fedora:
>       job: amd64-fedora-container
>     variables:
>       IMAGE: fedora
> -    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
> +    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
>       TARGETS: microblaze-softmmu mips-softmmu
>         xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
>       MAKE_CHECK_ARGS: check-build
Re: [PATCH] gitlab: enable afalg tests in fedora system test
Posted by Thomas Huth 15 hours ago 
On 21/10/2024 19.02, Daniel P. Berrangé wrote:
> The AF_ALG crypto integration for Linux is not being tested in
> any CI scenario. It always requires an explicit configure time
> flag to be passed to turn it on. The Fedora system test is
> arbitrarily picked as the place to test it.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   .gitlab-ci.d/buildtest.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This is to detect the situation Markus found here:
> 
>    https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
> 
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index 01e8470a69..f0cbdf1992 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -115,7 +115,7 @@ build-system-fedora:
>       job: amd64-fedora-container
>     variables:
>       IMAGE: fedora
> -    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
> +    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
>       TARGETS: microblaze-softmmu mips-softmmu
>         xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
>       MAKE_CHECK_ARGS: check-build

Is there a reason for this feature being disabled by default? Who is using 
it if it is disabled by default? Should we maybe rather enable it by default 
instead?

  Thomas
Re: [PATCH] gitlab: enable afalg tests in fedora system test
Posted by Daniel P. Berrangé 12 hours ago 
On Tue, Oct 22, 2024 at 07:31:49AM +0200, Thomas Huth wrote:
> On 21/10/2024 19.02, Daniel P. Berrangé wrote:
> > The AF_ALG crypto integration for Linux is not being tested in
> > any CI scenario. It always requires an explicit configure time
> > flag to be passed to turn it on. The Fedora system test is
> > arbitrarily picked as the place to test it.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   .gitlab-ci.d/buildtest.yml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > This is to detect the situation Markus found here:
> > 
> >    https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
> > 
> > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> > index 01e8470a69..f0cbdf1992 100644
> > --- a/.gitlab-ci.d/buildtest.yml
> > +++ b/.gitlab-ci.d/buildtest.yml
> > @@ -115,7 +115,7 @@ build-system-fedora:
> >       job: amd64-fedora-container
> >     variables:
> >       IMAGE: fedora
> > -    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
> > +    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
> >       TARGETS: microblaze-softmmu mips-softmmu
> >         xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
> >       MAKE_CHECK_ARGS: check-build
> 
> Is there a reason for this feature being disabled by default? Who is using
> it if it is disabled by default? Should we maybe rather enable it by default
> instead?

afalg isn't something you want to use in general. It performs worse than
the userspace crypto in many cases, especially for small buffers where the
context switch overhead kills.

It is potentially interesting if you have hardware crypto accelerator and
your guest workload also wants virtio-crypto.

Having it as a compile time option is not ideal, but it was the least
effort tradeoff.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH] gitlab: enable afalg tests in fedora system test
Posted by Thomas Huth 12 hours ago 
On 22/10/2024 10.03, Daniel P. Berrangé wrote:
> On Tue, Oct 22, 2024 at 07:31:49AM +0200, Thomas Huth wrote:
>> On 21/10/2024 19.02, Daniel P. Berrangé wrote:
>>> The AF_ALG crypto integration for Linux is not being tested in
>>> any CI scenario. It always requires an explicit configure time
>>> flag to be passed to turn it on. The Fedora system test is
>>> arbitrarily picked as the place to test it.
>>>
>>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>>> ---
>>>    .gitlab-ci.d/buildtest.yml | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> This is to detect the situation Markus found here:
>>>
>>>     https://lists.nongnu.org/archive/html/qemu-devel/2024-10/msg03040.html
>>>
>>> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
>>> index 01e8470a69..f0cbdf1992 100644
>>> --- a/.gitlab-ci.d/buildtest.yml
>>> +++ b/.gitlab-ci.d/buildtest.yml
>>> @@ -115,7 +115,7 @@ build-system-fedora:
>>>        job: amd64-fedora-container
>>>      variables:
>>>        IMAGE: fedora
>>> -    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs
>>> +    CONFIGURE_ARGS: --disable-gcrypt --enable-nettle --enable-docs --enable-crypto-afalg
>>>        TARGETS: microblaze-softmmu mips-softmmu
>>>          xtensa-softmmu m68k-softmmu riscv32-softmmu ppc-softmmu sparc64-softmmu
>>>        MAKE_CHECK_ARGS: check-build
>>
>> Is there a reason for this feature being disabled by default? Who is using
>> it if it is disabled by default? Should we maybe rather enable it by default
>> instead?
> 
> afalg isn't something you want to use in general. It performs worse than
> the userspace crypto in many cases, especially for small buffers where the
> context switch overhead kills.
> 
> It is potentially interesting if you have hardware crypto accelerator and
> your guest workload also wants virtio-crypto.
> 
> Having it as a compile time option is not ideal, but it was the least
> effort tradeoff.

Ok, makes sense, thanks for the explanation.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH] gitlab: enable afalg tests in fedora system test
Posted by Philippe Mathieu-Daudé 16 hours ago 
On 21/10/24 14:02, Daniel P. Berrangé wrote:
> The AF_ALG crypto integration for Linux is not being tested in
> any CI scenario. It always requires an explicit configure time
> flag to be passed to turn it on. The Fedora system test is
> arbitrarily picked as the place to test it.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   .gitlab-ci.d/buildtest.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.