ui: various improvements to VNC SASL code

[PATCH 0/6] ui: various improvements to VNC SASL code

Posted by Daniel P. Berrangé 1 day, 4 hours ago

This fixes a few minor edge cases noticed when writing the formal
specification for the SASL VNC extension.

Daniel P. Berrangé (6):
  ui/vnc: don't return an empty SASL mechlist to the client
  ui/vnc: don't raise error formatting socket address for non-inet
  ui/vnc: fix skipping SASL SSF on UNIX sockets
  ui/vnc: don't check for SSF after SASL authentication on UNIX sockets
  ui: fix handling of NULL SASL server data
  ui: validate NUL byte padding in SASL client data more strictly

 ui/vnc-auth-sasl.c | 75 ++++++++++++++++++++++++++++++++--------------
 ui/vnc.c           |  3 --
 ui/vnc.h           |  1 -
 3 files changed, 52 insertions(+), 27 deletions(-)

-- 
2.46.0

Re: [PATCH 0/6] ui: various improvements to VNC SASL code

Posted by Marc-André Lureau 1 day, 2 hours ago

Hi Daniel

On Mon, Oct 21, 2024 at 8:21 PM Daniel P. Berrangé <berrange@redhat.com>
wrote:

> This fixes a few minor edge cases noticed when writing the formal
> specification for the SASL VNC extension.
>
> Daniel P. Berrangé (6):
>   ui/vnc: don't return an empty SASL mechlist to the client
>   ui/vnc: don't raise error formatting socket address for non-inet
>   ui/vnc: fix skipping SASL SSF on UNIX sockets
>   ui/vnc: don't check for SSF after SASL authentication on UNIX sockets
>   ui: fix handling of NULL SASL server data
>   ui: validate NUL byte padding in SASL client data more strictly
>

For the series:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


>  ui/vnc-auth-sasl.c | 75 ++++++++++++++++++++++++++++++++--------------
>  ui/vnc.c           |  3 --
>  ui/vnc.h           |  1 -
>  3 files changed, 52 insertions(+), 27 deletions(-)
>
> --
> 2.46.0
>
>
>

-- 
Marc-André Lureau