target/mips: Remove unused CPUMIPSState::current_fpu field

[PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field

Posted by Philippe Mathieu-Daudé 1 day, 5 hours ago

The 'current_fpu' field is unused since commit f01be154589
("Move the active FPU registers into env again, and use more
TCG registers to access them").

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/mips/cpu.h            | 1 -
 target/mips/sysemu/machine.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/mips/cpu.h b/target/mips/cpu.h
index 6a4c4ea683a..3c235f39ffc 100644
--- a/target/mips/cpu.h
+++ b/target/mips/cpu.h
@@ -530,7 +530,6 @@ typedef struct CPUArchState {
     CPUMIPSFPUContext active_fpu;
 
     uint32_t current_tc;
-    uint32_t current_fpu;
 
     uint32_t SEGBITS;
     uint32_t PABITS;
diff --git a/target/mips/sysemu/machine.c b/target/mips/sysemu/machine.c
index 91cd9f19002..8af11fd896b 100644
--- a/target/mips/sysemu/machine.c
+++ b/target/mips/sysemu/machine.c
@@ -242,7 +242,7 @@ const VMStateDescription vmstate_mips_cpu = {
 
         /* CPU metastate */
         VMSTATE_UINT32(env.current_tc, MIPSCPU),
-        VMSTATE_UINT32(env.current_fpu, MIPSCPU),
+        VMSTATE_UNUSED(sizeof(uint32_t)), /* was current_fpu */
         VMSTATE_INT32(env.error_code, MIPSCPU),
         VMSTATE_UINTTL(env.btarget, MIPSCPU),
         VMSTATE_UINTTL(env.bcond, MIPSCPU),
-- 
2.45.2

Re: [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field

Posted by Richard Henderson 1 day ago

On 10/21/24 08:12, Philippe Mathieu-Daudé wrote:
> The 'current_fpu' field is unused since commit f01be154589
> ("Move the active FPU registers into env again, and use more
> TCG registers to access them").
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   target/mips/cpu.h            | 1 -
>   target/mips/sysemu/machine.c | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field

Posted by Pierrick Bouvier 1 day, 3 hours ago

On 10/21/24 08:12, Philippe Mathieu-Daudé wrote:
> The 'current_fpu' field is unused since commit f01be154589
> ("Move the active FPU registers into env again, and use more
> TCG registers to access them").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/mips/cpu.h            | 1 -
>   target/mips/sysemu/machine.c | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/target/mips/cpu.h b/target/mips/cpu.h
> index 6a4c4ea683a..3c235f39ffc 100644
> --- a/target/mips/cpu.h
> +++ b/target/mips/cpu.h
> @@ -530,7 +530,6 @@ typedef struct CPUArchState {
>       CPUMIPSFPUContext active_fpu;
>   
>       uint32_t current_tc;
> -    uint32_t current_fpu;
>   
>       uint32_t SEGBITS;
>       uint32_t PABITS;
> diff --git a/target/mips/sysemu/machine.c b/target/mips/sysemu/machine.c
> index 91cd9f19002..8af11fd896b 100644
> --- a/target/mips/sysemu/machine.c
> +++ b/target/mips/sysemu/machine.c
> @@ -242,7 +242,7 @@ const VMStateDescription vmstate_mips_cpu = {
>   
>           /* CPU metastate */
>           VMSTATE_UINT32(env.current_tc, MIPSCPU),
> -        VMSTATE_UINT32(env.current_fpu, MIPSCPU),
> +        VMSTATE_UNUSED(sizeof(uint32_t)), /* was current_fpu */
>           VMSTATE_INT32(env.error_code, MIPSCPU),
>           VMSTATE_UINTTL(env.btarget, MIPSCPU),
>           VMSTATE_UINTTL(env.bcond, MIPSCPU),

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>