1. Patchew
  2. QEMU
  3. View series

[PATCH] dockerfiles: fix default targets for debian-loongarch-cross

Pierrick Bouvier posted 1 patch 1 day, 23 hours ago 
tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] dockerfiles: fix default targets for debian-loongarch-cross
Posted by Pierrick Bouvier 1 day, 23 hours ago 
fix system target name, and remove --disable-system (which deactivates
system target).

Found using: make docker-test-build@debian-loongarch-cross V=1

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
index 79eab5621ef..538ab534902 100644
--- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
+++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
@@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
 ENV PATH $PATH:/opt/cross-tools/bin
 ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
 
-ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
-ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
+ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
+ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
 ENV MAKE /usr/bin/make
 
 # As a final step configure the user (if env is defined)
-- 
2.39.5
Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
Posted by Alex Bennée 1 day, 12 hours ago 
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> fix system target name, and remove --disable-system (which deactivates
> system target).
>
> Found using: make docker-test-build@debian-loongarch-cross V=1
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>  tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> index 79eab5621ef..538ab534902 100644
> --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
> +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
>  ENV PATH $PATH:/opt/cross-tools/bin
>  ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
>  
> -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
> -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
> +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
> +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
>  ENV MAKE /usr/bin/make
>  
>  # As a final step configure the user (if env is defined)

Queued to testing/next, thanks.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
Posted by Philippe Mathieu-Daudé 1 day, 15 hours ago 
On 20/10/24 18:37, Pierrick Bouvier wrote:
> fix system target name, and remove --disable-system (which deactivates
> system target).
> 
> Found using: make docker-test-build@debian-loongarch-cross V=1
> 
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> index 79eab5621ef..538ab534902 100644
> --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
> +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
>   ENV PATH $PATH:/opt/cross-tools/bin
>   ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
>   
> -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
> -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
> +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
> +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
>   ENV MAKE /usr/bin/make
>   
>   # As a final step configure the user (if env is defined)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Re: [PATCH] dockerfiles: fix default targets for debian-loongarch-cross
Posted by Thomas Huth 1 day, 15 hours ago 
On 20/10/2024 23.37, Pierrick Bouvier wrote:
> fix system target name, and remove --disable-system (which deactivates
> system target).
> 
> Found using: make docker-test-build@debian-loongarch-cross V=1
> 
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   tests/docker/dockerfiles/debian-loongarch-cross.docker | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/docker/dockerfiles/debian-loongarch-cross.docker b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> index 79eab5621ef..538ab534902 100644
> --- a/tests/docker/dockerfiles/debian-loongarch-cross.docker
> +++ b/tests/docker/dockerfiles/debian-loongarch-cross.docker
> @@ -43,8 +43,8 @@ RUN curl -#SL https://github.com/loongson/build-tools/releases/download/2023.08.
>   ENV PATH $PATH:/opt/cross-tools/bin
>   ENV LD_LIBRARY_PATH /opt/cross-tools/lib:/opt/cross-tools/loongarch64-unknown-linux-gnu/lib:$LD_LIBRARY_PATH
>   
> -ENV QEMU_CONFIGURE_OPTS --disable-system --disable-docs --disable-tools
> -ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch-softmmu
> +ENV QEMU_CONFIGURE_OPTS --disable-docs --disable-tools
> +ENV DEF_TARGET_LIST loongarch64-linux-user,loongarch64-softmmu
>   ENV MAKE /usr/bin/make
>   
>   # As a final step configure the user (if env is defined)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.