[PATCH] configure: Replace literally printed '\n' with newline

Kevin Wolf posted 1 patch 4 days, 8 hours ago
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] configure: Replace literally printed '\n' with newline
Posted by Kevin Wolf 4 days, 8 hours ago
The idea here was to leave an empty line before the message, but by
default, echo prints '\n' literally instead of interpreting it. Use a
separate echo without parameter instead like in other places in the
script.

Fixes: 6fdc5bc173188f5e4942616b16d589500b874a15
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 configure | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 72d1a94225..0918147156 100755
--- a/configure
+++ b/configure
@@ -2062,7 +2062,8 @@ chmod +x config.status
 rm -r "$TMPDIR1"
 
 if test "$rust" != disabled; then
-  echo '\nINFO: Rust bindings generation with `bindgen` might fail in some cases where'
+  echo
+  echo 'INFO: Rust bindings generation with `bindgen` might fail in some cases where'
   echo 'the detected `libclang` does not match the expected `clang` version/target. In'
   echo 'this case you must pass the path to `clang` and `libclang` to your build'
   echo 'command invocation using the environment variables CLANG_PATH and LIBCLANG_PATH'
-- 
2.47.0
Re: [PATCH] configure: Replace literally printed '\n' with newline
Posted by Paolo Bonzini 1 day, 8 hours ago
Queued, thanks.

Paolo
Re: [PATCH] configure: Replace literally printed '\n' with newline
Posted by Daniel P. Berrangé 4 days, 8 hours ago
On Fri, Oct 18, 2024 at 02:05:57PM +0200, Kevin Wolf wrote:
> The idea here was to leave an empty line before the message, but by
> default, echo prints '\n' literally instead of interpreting it. Use a
> separate echo without parameter instead like in other places in the
> script.
> 
> Fixes: 6fdc5bc173188f5e4942616b16d589500b874a15
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|