[v1] Fix write incorrect data into flash in user mode

[PATCH v1 07/16] test/qtest/aspeed_smc-test: Fix coding style

Posted by Jamin Lin via 4 days, 18 hours ago

Fix coding style issues from checkpatch.pl

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 tests/qtest/aspeed_smc-test.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
index c713a3700b..4673371d95 100644
--- a/tests/qtest/aspeed_smc-test.c
+++ b/tests/qtest/aspeed_smc-test.c
@@ -353,7 +353,8 @@ static void test_read_page_mem(void)
     uint32_t page[FLASH_PAGE_SIZE / 4];
     int i;
 
-    /* Enable 4BYTE mode for controller. This is should be strapped by
+    /*
+     * Enable 4BYTE mode for controller. This is should be strapped by
      * HW for CE0 anyhow.
      */
     spi_ce_ctrl(1 << CRTL_EXTENDED0);
@@ -394,7 +395,8 @@ static void test_write_page_mem(void)
     uint32_t page[FLASH_PAGE_SIZE / 4];
     int i;
 
-    /* Enable 4BYTE mode for controller. This is should be strapped by
+    /*
+     * Enable 4BYTE mode for controller. This is should be strapped by
      * HW for CE0 anyhow.
      */
     spi_ce_ctrl(1 << CRTL_EXTENDED0);
-- 
2.34.1

Re: [SPAM] [PATCH v1 07/16] test/qtest/aspeed_smc-test: Fix coding style

Posted by Cédric Le Goater 1 day, 11 hours ago

On 10/18/24 07:31, Jamin Lin wrote:
> Fix coding style issues from checkpatch.pl
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   tests/qtest/aspeed_smc-test.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
> index c713a3700b..4673371d95 100644
> --- a/tests/qtest/aspeed_smc-test.c
> +++ b/tests/qtest/aspeed_smc-test.c
> @@ -353,7 +353,8 @@ static void test_read_page_mem(void)
>       uint32_t page[FLASH_PAGE_SIZE / 4];
>       int i;
>   
> -    /* Enable 4BYTE mode for controller. This is should be strapped by
> +    /*
> +     * Enable 4BYTE mode for controller. This is should be strapped by
>        * HW for CE0 anyhow.
>        */
>       spi_ce_ctrl(1 << CRTL_EXTENDED0);
> @@ -394,7 +395,8 @@ static void test_write_page_mem(void)
>       uint32_t page[FLASH_PAGE_SIZE / 4];
>       int i;
>   
> -    /* Enable 4BYTE mode for controller. This is should be strapped by
> +    /*
> +     * Enable 4BYTE mode for controller. This is should be strapped by
>        * HW for CE0 anyhow.
>        */
>       spi_ce_ctrl(1 << CRTL_EXTENDED0);

Re: [PATCH v1 07/16] test/qtest/aspeed_smc-test: Fix coding style

Posted by Thomas Huth 4 days, 15 hours ago

On 18/10/2024 07.31, Jamin Lin wrote:
> Fix coding style issues from checkpatch.pl
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/qtest/aspeed_smc-test.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c
> index c713a3700b..4673371d95 100644
> --- a/tests/qtest/aspeed_smc-test.c
> +++ b/tests/qtest/aspeed_smc-test.c
> @@ -353,7 +353,8 @@ static void test_read_page_mem(void)
>       uint32_t page[FLASH_PAGE_SIZE / 4];
>       int i;
>   
> -    /* Enable 4BYTE mode for controller. This is should be strapped by
> +    /*
> +     * Enable 4BYTE mode for controller. This is should be strapped by
>        * HW for CE0 anyhow.
>        */
>       spi_ce_ctrl(1 << CRTL_EXTENDED0);
> @@ -394,7 +395,8 @@ static void test_write_page_mem(void)
>       uint32_t page[FLASH_PAGE_SIZE / 4];
>       int i;
>   
> -    /* Enable 4BYTE mode for controller. This is should be strapped by
> +    /*
> +     * Enable 4BYTE mode for controller. This is should be strapped by
>        * HW for CE0 anyhow.
>        */
>       spi_ce_ctrl(1 << CRTL_EXTENDED0);

Reviewed-by: Thomas Huth <thuth@redhat.com>