[v2] include: move include/qapi/qmp/ to include/qobject/

[PATCH v2 31/31] system: remove unused qerror.h header

Posted by Daniel P. Berrangé 5 days, 10 hours ago

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 system/rtc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/system/rtc.c b/system/rtc.c
index e3bc2095f9..216d2aee3a 100644
--- a/system/rtc.c
+++ b/system/rtc.c
@@ -25,7 +25,6 @@
 #include "qemu/osdep.h"
 #include "qemu/cutils.h"
 #include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
 #include "qemu/error-report.h"
 #include "qemu/option.h"
 #include "qemu/timer.h"
-- 
2.46.0

Re: [PATCH v2 31/31] system: remove unused qerror.h header

Posted by Zhao Liu 4 days, 12 hours ago

Hi Daniel,

On Thu, Oct 17, 2024 at 12:33:43PM +0100, Daniel P. Berrangé wrote:
> Date: Thu, 17 Oct 2024 12:33:43 +0100
> From: "Daniel P. Berrangé" <berrange@redhat.com>
> Subject: [PATCH v2 31/31] system: remove unused qerror.h header
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  system/rtc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/system/rtc.c b/system/rtc.c
> index e3bc2095f9..216d2aee3a 100644
> --- a/system/rtc.c
> +++ b/system/rtc.c
> @@ -25,7 +25,6 @@
>  #include "qemu/osdep.h"
>  #include "qemu/cutils.h"
>  #include "qapi/error.h"
> -#include "qapi/qmp/qerror.h"
>  #include "qemu/error-report.h"
>  #include "qemu/option.h"
>  #include "qemu/timer.h"
> -- 
> 2.46.0
> 

Ah, this qerror.h is added by patch 23 accidentally.

Regards,
Zhao

Re: [PATCH v2 31/31] system: remove unused qerror.h header

Posted by Daniel P. Berrangé 4 days, 8 hours ago

On Fri, Oct 18, 2024 at 06:17:15PM +0800, Zhao Liu wrote:
> Hi Daniel,
> 
> On Thu, Oct 17, 2024 at 12:33:43PM +0100, Daniel P. Berrangé wrote:
> > Date: Thu, 17 Oct 2024 12:33:43 +0100
> > From: "Daniel P. Berrangé" <berrange@redhat.com>
> > Subject: [PATCH v2 31/31] system: remove unused qerror.h header
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  system/rtc.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/system/rtc.c b/system/rtc.c
> > index e3bc2095f9..216d2aee3a 100644
> > --- a/system/rtc.c
> > +++ b/system/rtc.c
> > @@ -25,7 +25,6 @@
> >  #include "qemu/osdep.h"
> >  #include "qemu/cutils.h"
> >  #include "qapi/error.h"
> > -#include "qapi/qmp/qerror.h"
> >  #include "qemu/error-report.h"
> >  #include "qemu/option.h"
> >  #include "qemu/timer.h"
> > -- 
> > 2.46.0
> > 
> 
> Ah, this qerror.h is added by patch 23 accidentally.

Doh, fixing my own mistake :-)


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|