[PATCH 02/16] meson: remove repeated search for rust_root_crate.sh

Paolo Bonzini posted 16 patches 1 week ago
There is a newer version of this series
[PATCH 02/16] meson: remove repeated search for rust_root_crate.sh
Posted by Paolo Bonzini 1 week ago
Avoid repeated lines of the form

Program scripts/rust/rust_root_crate.sh found: YES (/home/pbonzini/work/upstream/qemu/scripts/rust/rust_root_crate.sh)

in the meson logs.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index c2e736d2051..37f94ab32aa 100644
--- a/meson.build
+++ b/meson.build
@@ -3977,6 +3977,7 @@ endif
 
 
 feature_to_c = find_program('scripts/feature_to_c.py')
+rust_root_crate = find_program('scripts/rust/rust_root_crate.sh')
 
 if host_os == 'darwin'
   entitlement = find_program('scripts/entitlement.sh')
@@ -4078,7 +4079,7 @@ foreach target : target_dirs
     if crates.length() > 0
       rlib_rs = custom_target('rust_' + target.underscorify() + '.rs',
                               output: 'rust_' + target.underscorify() + '.rs',
-                              command: [find_program('scripts/rust/rust_root_crate.sh')] + crates,
+                              command: [rust_root_crate, crates],
                               capture: true,
                               build_by_default: true,
                               build_always_stale: true)
-- 
2.46.2
Re: [PATCH 02/16] meson: remove repeated search for rust_root_crate.sh
Posted by Zhao Liu 4 days, 7 hours ago
On Tue, Oct 15, 2024 at 03:17:20PM +0200, Paolo Bonzini wrote:
> Date: Tue, 15 Oct 2024 15:17:20 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 02/16] meson: remove repeated search for rust_root_crate.sh
> X-Mailer: git-send-email 2.46.2
> 
> Avoid repeated lines of the form
> 
> Program scripts/rust/rust_root_crate.sh found: YES (/home/pbonzini/work/upstream/qemu/scripts/rust/rust_root_crate.sh)
> 
> in the meson logs.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Re: [PATCH 02/16] meson: remove repeated search for rust_root_crate.sh
Posted by Junjie Mao 6 days, 15 hours ago
Paolo Bonzini <pbonzini@redhat.com> writes:

> Avoid repeated lines of the form
>
> Program scripts/rust/rust_root_crate.sh found: YES (/home/pbonzini/work/upstream/qemu/scripts/rust/rust_root_crate.sh)
>
> in the meson logs.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Junjie Mao <junjie.mao@hotmail.com>

Thanks for cleaning this up!

--
Best Regards
Junjie Mao