[PATCH] target/mips: Remove unused MEMOP_IDX() macro

Philippe Mathieu-Daudé posted 1 patch 1 week ago
target/mips/tcg/msa_helper.c | 8 --------
1 file changed, 8 deletions(-)
[PATCH] target/mips: Remove unused MEMOP_IDX() macro
Posted by Philippe Mathieu-Daudé 1 week ago
MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips:
Use cpu_*_data_ra for msa load/store"), remove it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/mips/tcg/msa_helper.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c
index d2181763e72..1d40383ca4f 100644
--- a/target/mips/tcg/msa_helper.c
+++ b/target/mips/tcg/msa_helper.c
@@ -8211,14 +8211,6 @@ void helper_msa_ffint_u_df(CPUMIPSState *env, uint32_t df, uint32_t wd,
 /* Element-by-element access macros */
 #define DF_ELEMENTS(df) (MSA_WRLEN / DF_BITS(df))
 
-#if !defined(CONFIG_USER_ONLY)
-#define MEMOP_IDX(DF)                                                   \
-    MemOpIdx oi = make_memop_idx(MO_TE | DF | MO_UNALN,                 \
-                                 mips_env_mmu_index(env));
-#else
-#define MEMOP_IDX(DF)
-#endif
-
 #if TARGET_BIG_ENDIAN
 static inline uint64_t bswap16x4(uint64_t x)
 {
-- 
2.45.2


Re: [PATCH] target/mips: Remove unused MEMOP_IDX() macro
Posted by Richard Henderson 1 week ago
On 10/14/24 16:22, Philippe Mathieu-Daudé wrote:
> MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips:
> Use cpu_*_data_ra for msa load/store"), remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   target/mips/tcg/msa_helper.c | 8 --------
>   1 file changed, 8 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Re: [PATCH] target/mips: Remove unused MEMOP_IDX() macro
Posted by Philippe Mathieu-Daudé 1 week ago
On 14/10/24 21:09, Richard Henderson wrote:
> On 10/14/24 16:22, Philippe Mathieu-Daudé wrote:
>> MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips:
>> Use cpu_*_data_ra for msa load/store"), remove it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
>> ---
>>   target/mips/tcg/msa_helper.c | 8 --------
>>   1 file changed, 8 deletions(-)
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks, patch queued.