[PULL 00/20] UI patches

marcandre.lureau@redhat.com posted 20 patches 1 month, 1 week ago
meson.build                     |   2 +-
include/hw/virtio/virtio-gpu.h  |   4 +-
include/ui/qemu-pixman.h        |  24 +++++
include/ui/surface.h            |  14 ++-
audio/pwaudio.c                 |   8 +-
hw/audio/hda-codec.c            |  33 ++++---
hw/display/virtio-gpu.c         |  69 ++++----------
tests/qtest/dbus-display-test.c |  72 ++++++++++++++-
ui/console.c                    |  78 ++++++----------
ui/dbus-console.c               |  23 +----
ui/dbus-listener.c              | 159 ++++++++++++++++++++++++++++----
ui/qemu-pixman.c                |  71 ++++++++++++++
util/memfd.c                    |   9 +-
ui/dbus-display1.xml            |  49 ++++++++++
ui/trace-events                 |   1 +
15 files changed, 444 insertions(+), 172 deletions(-)
[PULL 00/20] UI patches
Posted by marcandre.lureau@redhat.com 1 month, 1 week ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following changes since commit 3860a2a8de56fad71db42f4ad120eb7eff03b51f:

  Merge tag 'pull-tcg-20241013' of https://gitlab.com/rth7680/qemu into staging (2024-10-14 11:12:34 +0100)

are available in the Git repository at:

  https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request

for you to fetch changes up to 4cd78a3db2478d3c1527905a26c9d3fbee83ccac:

  audio/pw: Report more accurate error when connecting to PipeWire fails (2024-10-14 17:35:24 +0400)

----------------------------------------------------------------
UI-related fixes & shareable 2d memory with -display dbus

----------------------------------------------------------------

Marc-André Lureau (19):
  hw/audio/hda: free timer on exit
  hw/audio/hda: fix memory leak on audio setup
  ui/dbus: fix leak on message filtering
  ui/win32: fix potential use-after-free with dbus shared memory
  ui/dbus: fix filtering all update messages
  ui/dbus: discard display messages on disable
  ui/dbus: discard pending CursorDefine on new one
  util/memfd: report potential errors on free
  ui/pixman: generalize shared_image_destroy
  ui/dbus: do not limit to one listener per connection / bus name
  ui/dbus: add trace for can_share_map
  ui/surface: allocate shared memory on !win32
  meson: find_program('gdbus-codegen') directly
  ui/dbus: make Listener.Win32.Map win32-specific
  ui/dbus: add Listener.Unix.Map interface XML
  ui/dbus: implement Unix.Map
  virtio-gpu: allocate shareable 2d resources on !win32
  ui: refactor using a common qemu_pixman_shareable
  tests: add basic -display dbus Map.Unix test

Michal Privoznik (1):
  audio/pw: Report more accurate error when connecting to PipeWire fails

 meson.build                     |   2 +-
 include/hw/virtio/virtio-gpu.h  |   4 +-
 include/ui/qemu-pixman.h        |  24 +++++
 include/ui/surface.h            |  14 ++-
 audio/pwaudio.c                 |   8 +-
 hw/audio/hda-codec.c            |  33 ++++---
 hw/display/virtio-gpu.c         |  69 ++++----------
 tests/qtest/dbus-display-test.c |  72 ++++++++++++++-
 ui/console.c                    |  78 ++++++----------
 ui/dbus-console.c               |  23 +----
 ui/dbus-listener.c              | 159 ++++++++++++++++++++++++++++----
 ui/qemu-pixman.c                |  71 ++++++++++++++
 util/memfd.c                    |   9 +-
 ui/dbus-display1.xml            |  49 ++++++++++
 ui/trace-events                 |   1 +
 15 files changed, 444 insertions(+), 172 deletions(-)

-- 
2.47.0


Re: [PULL 00/20] UI patches
Posted by Peter Maydell 1 month, 1 week ago
On Mon, 14 Oct 2024 at 14:39, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 3860a2a8de56fad71db42f4ad120eb7eff03b51f:
>
>   Merge tag 'pull-tcg-20241013' of https://gitlab.com/rth7680/qemu into staging (2024-10-14 11:12:34 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request
>
> for you to fetch changes up to 4cd78a3db2478d3c1527905a26c9d3fbee83ccac:
>
>   audio/pw: Report more accurate error when connecting to PipeWire fails (2024-10-14 17:35:24 +0400)
>
> ----------------------------------------------------------------
> UI-related fixes & shareable 2d memory with -display dbus
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/9.2
for any user-visible changes.

-- PMM
Re: [PULL 00/20] UI patches
Posted by Michael Tokarev 1 month, 1 week ago
On 14.10.2024 16:39, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The following changes since commit 3860a2a8de56fad71db42f4ad120eb7eff03b51f:
> 
>    Merge tag 'pull-tcg-20241013' of https://gitlab.com/rth7680/qemu into staging (2024-10-14 11:12:34 +0100)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request
> 
> for you to fetch changes up to 4cd78a3db2478d3c1527905a26c9d3fbee83ccac:
> 
>    audio/pw: Report more accurate error when connecting to PipeWire fails (2024-10-14 17:35:24 +0400)
> 
> ----------------------------------------------------------------
> UI-related fixes & shareable 2d memory with -display dbus
> 
> ----------------------------------------------------------------
> 
> Marc-André Lureau (19):
>    hw/audio/hda: free timer on exit
>    hw/audio/hda: fix memory leak on audio setup
>    ui/dbus: fix leak on message filtering
>    ui/win32: fix potential use-after-free with dbus shared memory
>    ui/dbus: fix filtering all update messages
>    ui/dbus: discard display messages on disable
>    ui/dbus: discard pending CursorDefine on new one
>    util/memfd: report potential errors on free
>    ui/pixman: generalize shared_image_destroy
>    ui/dbus: do not limit to one listener per connection / bus name
>    ui/dbus: add trace for can_share_map
>    ui/surface: allocate shared memory on !win32
>    meson: find_program('gdbus-codegen') directly
>    ui/dbus: make Listener.Win32.Map win32-specific
>    ui/dbus: add Listener.Unix.Map interface XML
>    ui/dbus: implement Unix.Map
>    virtio-gpu: allocate shareable 2d resources on !win32
>    ui: refactor using a common qemu_pixman_shareable
>    tests: add basic -display dbus Map.Unix test
> 
> Michal Privoznik (1):
>    audio/pw: Report more accurate error when connecting to PipeWire fails

Or, actually, here (I replied to a wrong thread) -- is there something
for qemu-stable in there?  First 7 changes seems to be good fit there.

Thanks,

/mjt


Re: [PULL 00/20] UI patches
Posted by Marc-André Lureau 1 month, 1 week ago
Hi Michael

On Tue, Oct 15, 2024 at 9:40 PM Michael Tokarev <mjt@tls.msk.ru> wrote:

> On 14.10.2024 16:39, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The following changes since commit
> 3860a2a8de56fad71db42f4ad120eb7eff03b51f:
> >
> >    Merge tag 'pull-tcg-20241013' of https://gitlab.com/rth7680/qemu
> into staging (2024-10-14 11:12:34 +0100)
> >
> > are available in the Git repository at:
> >
> >    https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request
> >
> > for you to fetch changes up to 4cd78a3db2478d3c1527905a26c9d3fbee83ccac:
> >
> >    audio/pw: Report more accurate error when connecting to PipeWire
> fails (2024-10-14 17:35:24 +0400)
> >
> > ----------------------------------------------------------------
> > UI-related fixes & shareable 2d memory with -display dbus
> >
> > ----------------------------------------------------------------
> >
> > Marc-André Lureau (19):
> >    hw/audio/hda: free timer on exit
> >    hw/audio/hda: fix memory leak on audio setup
> >    ui/dbus: fix leak on message filtering
> >    ui/win32: fix potential use-after-free with dbus shared memory
> >    ui/dbus: fix filtering all update messages
> >    ui/dbus: discard display messages on disable
> >    ui/dbus: discard pending CursorDefine on new one
> >    util/memfd: report potential errors on free
> >    ui/pixman: generalize shared_image_destroy
> >    ui/dbus: do not limit to one listener per connection / bus name
> >    ui/dbus: add trace for can_share_map
> >    ui/surface: allocate shared memory on !win32
> >    meson: find_program('gdbus-codegen') directly
> >    ui/dbus: make Listener.Win32.Map win32-specific
> >    ui/dbus: add Listener.Unix.Map interface XML
> >    ui/dbus: implement Unix.Map
> >    virtio-gpu: allocate shareable 2d resources on !win32
> >    ui: refactor using a common qemu_pixman_shareable
> >    tests: add basic -display dbus Map.Unix test
> >
> > Michal Privoznik (1):
> >    audio/pw: Report more accurate error when connecting to PipeWire fails
>
> Or, actually, here (I replied to a wrong thread) -- is there something
> for qemu-stable in there?  First 7 changes seems to be good fit there.
>

Or only the first 5. It would be nice to have a second look before!

thanks

-- 
Marc-André Lureau
Re: [PULL 00/20] UI patches
Posted by Michael Tokarev 3 weeks, 4 days ago
16.10.2024 09:34, Marc-André Lureau wrote:
> Hi Michael

>      > Marc-André Lureau (19):
>      >    hw/audio/hda: free timer on exit
>      >    hw/audio/hda: fix memory leak on audio setup
>      >    ui/dbus: fix leak on message filtering
>      >    ui/win32: fix potential use-after-free with dbus shared memory
>      >    ui/dbus: fix filtering all update messages


>     Or, actually, here (I replied to a wrong thread) -- is there something
>     for qemu-stable in there?  First 7 changes seems to be good fit there.
> 
> 
> Or only the first 5. It would be nice to have a second look before!

So.. the second look has apparently been needed ;)

See https://gitlab.com/qemu-project/qemu/-/issues/2639

I'm not yet sure what's going on there, but will try to take a look
hopefullt later today.

/mjt