[PATCH v2 0/4] block: Miscellaneous minor Coverity fixes

Peter Maydell posted 4 patches 1 month, 2 weeks ago
block/gluster.c            |  7 ++-----
block/ssh.c                | 12 +++++++-----
block/vdi.c                |  4 ++--
tests/qemu-iotests/211.out |  6 +++---
4 files changed, 14 insertions(+), 15 deletions(-)
[PATCH v2 0/4] block: Miscellaneous minor Coverity fixes
Posted by Peter Maydell 1 month, 2 weeks ago
This patchset is the remaining stragglers from my
first set of "minor Coverity fixes" patches posted a
couple of months back:
https://patchew.org/QEMU/20240731143617.3391947-1-peter.maydell@linaro.org/
Of that series, patches 3, 4, 5 and 6 are upstream now.

In this v2 series:
 * patch 1 (old patch 2) has had a long line wrapped;
   already reviewed
 * patch 2 (old patch 7) now has hex2decimal() return "UINT_MAX"
   instead of "-1"; already reviewed
 * patch 3 is new, and fixes an error in an iotests reference
   output file that's been lurking around for a few years now
 * patch 4 (replacement for old patch 1) takes Kevin Wolf's
   suggestion to make vdi SECTOR_SIZE a 64-bit constant so we
   don't have to carefully cast it every time we want to use
   it in a multiplication

Patches 3 and 4 need review; patch 4 passes "./check -vdi"
except that 297 (the python-linter) fails for unrelated reasons.

thanks
-- PMM

Peter Maydell (4):
  block/gluster: Use g_autofree for string in qemu_gluster_parse_json()
  block/ssh.c: Don't double-check that characters are hex digits
  tests/qemu-iotests/211.out: Update to expect MapEntry 'compressed'
    field
  block/vdi.c: Make SECTOR_SIZE constant 64-bits

 block/gluster.c            |  7 ++-----
 block/ssh.c                | 12 +++++++-----
 block/vdi.c                |  4 ++--
 tests/qemu-iotests/211.out |  6 +++---
 4 files changed, 14 insertions(+), 15 deletions(-)

-- 
2.34.1
Re: [PATCH v2 0/4] block: Miscellaneous minor Coverity fixes
Posted by Kevin Wolf 1 month ago
Am 08.10.2024 um 18:47 hat Peter Maydell geschrieben:
> This patchset is the remaining stragglers from my
> first set of "minor Coverity fixes" patches posted a
> couple of months back:
> https://patchew.org/QEMU/20240731143617.3391947-1-peter.maydell@linaro.org/
> Of that series, patches 3, 4, 5 and 6 are upstream now.
> 
> In this v2 series:
>  * patch 1 (old patch 2) has had a long line wrapped;
>    already reviewed
>  * patch 2 (old patch 7) now has hex2decimal() return "UINT_MAX"
>    instead of "-1"; already reviewed
>  * patch 3 is new, and fixes an error in an iotests reference
>    output file that's been lurking around for a few years now
>  * patch 4 (replacement for old patch 1) takes Kevin Wolf's
>    suggestion to make vdi SECTOR_SIZE a 64-bit constant so we
>    don't have to carefully cast it every time we want to use
>    it in a multiplication
> 
> Patches 3 and 4 need review; patch 4 passes "./check -vdi"
> except that 297 (the python-linter) fails for unrelated reasons.

Thanks, applied to the block branch.

Kevin