[PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s

Peter Maydell posted 1 patch 1 month, 2 weeks ago
tests/qtest/meson.build | 1 +
1 file changed, 1 insertion(+)
[PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s
Posted by Peter Maydell 1 month, 2 weeks ago
The qmp-cmd-test test takes typically about 15s on my local machine.
On the k8s runners it takes usually 20s but sometimes about 60s,
because the k8s runners have wildly variable execution time.  If
they're running slow, we hit the default timeout.  Bump the
qmp-cmd-test timeout to 120s to avoid this.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 tests/qtest/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 2b90abf0007..b207e386965 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -7,6 +7,7 @@ slow_qtests = {
   'migration-test' : 480,
   'npcm7xx_pwm-test': 300,
   'npcm7xx_watchdog_timer-test': 120,
+  'qmp-cmd-test' : 120,
   'qom-test' : 900,
   'stm32l4x5_usart-test' : 600,
   'test-hmp' : 240,
-- 
2.34.1
Re: [PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s
Posted by Thomas Huth 1 month, 2 weeks ago
On 08/10/2024 16.13, Peter Maydell wrote:
> The qmp-cmd-test test takes typically about 15s on my local machine.
> On the k8s runners it takes usually 20s but sometimes about 60s,
> because the k8s runners have wildly variable execution time.  If
> they're running slow, we hit the default timeout.  Bump the
> qmp-cmd-test timeout to 120s to avoid this.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   tests/qtest/meson.build | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 2b90abf0007..b207e386965 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -7,6 +7,7 @@ slow_qtests = {
>     'migration-test' : 480,
>     'npcm7xx_pwm-test': 300,
>     'npcm7xx_watchdog_timer-test': 120,
> +  'qmp-cmd-test' : 120,
>     'qom-test' : 900,
>     'stm32l4x5_usart-test' : 600,
>     'test-hmp' : 240,

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH] tests/qtest: Bump qmp-cmd-test timeout to 120s
Posted by Peter Maydell 1 month, 2 weeks ago
On Tue, 8 Oct 2024 at 15:16, Thomas Huth <thuth@redhat.com> wrote:
>
> On 08/10/2024 16.13, Peter Maydell wrote:
> > The qmp-cmd-test test takes typically about 15s on my local machine.
> > On the k8s runners it takes usually 20s but sometimes about 60s,
> > because the k8s runners have wildly variable execution time.  If
> > they're running slow, we hit the default timeout.  Bump the
> > qmp-cmd-test timeout to 120s to avoid this.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   tests/qtest/meson.build | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> > index 2b90abf0007..b207e386965 100644
> > --- a/tests/qtest/meson.build
> > +++ b/tests/qtest/meson.build
> > @@ -7,6 +7,7 @@ slow_qtests = {
> >     'migration-test' : 480,
> >     'npcm7xx_pwm-test': 300,
> >     'npcm7xx_watchdog_timer-test': 120,
> > +  'qmp-cmd-test' : 120,
> >     'qom-test' : 900,
> >     'stm32l4x5_usart-test' : 600,
> >     'test-hmp' : 240,
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Applied directly to hopefully reduce CI flakiness.

thanks
-- PMM