[v1] misc: Use explicit endian LD/ST API

[PATCH 02/16] exec/memop: Remove unused memop_big_endian() helper

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

Last use of memop_big_endian() was removed in commit 592134617c9
("accel/tcg: Reorg system mode store helpers").

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/exec/memop.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/exec/memop.h b/include/exec/memop.h
index f881fe7af4e..899ea0a2aae 100644
--- a/include/exec/memop.h
+++ b/include/exec/memop.h
@@ -164,10 +164,4 @@ static inline MemOp size_memop(unsigned size)
     return (MemOp)ctz32(size);
 }
 
-/* Big endianness from MemOp.  */
-static inline bool memop_big_endian(MemOp op)
-{
-    return (op & MO_BSWAP) == MO_BE;
-}
-
 #endif
-- 
2.45.2

Re: [PATCH 02/16] exec/memop: Remove unused memop_big_endian() helper

Posted by Thomas Huth 1 month, 2 weeks ago

On 04/10/2024 01.41, Philippe Mathieu-Daudé wrote:
> Last use of memop_big_endian() was removed in commit 592134617c9
> ("accel/tcg: Reorg system mode store helpers").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/exec/memop.h | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/include/exec/memop.h b/include/exec/memop.h
> index f881fe7af4e..899ea0a2aae 100644
> --- a/include/exec/memop.h
> +++ b/include/exec/memop.h
> @@ -164,10 +164,4 @@ static inline MemOp size_memop(unsigned size)
>       return (MemOp)ctz32(size);
>   }
>   
> -/* Big endianness from MemOp.  */
> -static inline bool memop_big_endian(MemOp op)
> -{
> -    return (op & MO_BSWAP) == MO_BE;
> -}
> -
>   #endif

Reviewed-by: Thomas Huth <thuth@redhat.com>