[v1] misc: Use explicit endian LD/ST API

[PATCH 01/16] qemu/bswap: Undefine CPU_CONVERT() once done

Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago

Better undefined macros once we are done with them,
like we do few lines later with DO_STN_LDN_P().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/qemu/bswap.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index ad22910a5d1..b915835bead 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -140,6 +140,8 @@ CPU_CONVERT(le, 16, uint16_t)
 CPU_CONVERT(le, 32, uint32_t)
 CPU_CONVERT(le, 64, uint64_t)
 
+#undef CPU_CONVERT
+
 /*
  * Same as cpu_to_le{16,32,64}, except that gcc will figure the result is
  * a compile-time constant if you pass in a constant.  So this can be
-- 
2.45.2

Re: [PATCH 01/16] qemu/bswap: Undefine CPU_CONVERT() once done

Posted by Thomas Huth 1 month, 2 weeks ago

On 04/10/2024 01.41, Philippe Mathieu-Daudé wrote:
> Better undefined macros once we are done with them,
> like we do few lines later with DO_STN_LDN_P().
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/qemu/bswap.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index ad22910a5d1..b915835bead 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -140,6 +140,8 @@ CPU_CONVERT(le, 16, uint16_t)
>   CPU_CONVERT(le, 32, uint32_t)
>   CPU_CONVERT(le, 64, uint64_t)
>   
> +#undef CPU_CONVERT
> +

Reviewed-by: Thomas Huth <thuth@redhat.com>