1. Patchew
  2. QEMU
  3. View series

[PULL 00/22] -Werror=maybe-uninitialized fixes

marcandre.lureau@redhat.com posted 22 patches 1 year, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20241002083646.2893078-1-marcandre.lureau@redhat.com
Maintainers: John Snow <jsnow@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Greg Kurz <groug@kaod.org>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, Stefano Garzarella <sgarzare@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Bin Meng <bmeng.cn@gmail.com>, "Eugenio Pérez" <eperezma@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Hyman Huang <yong.huang@smartx.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Eric Blake <eblake@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Song Gao <gaosong@loongson.cn>
There is a newer version of this series
block/block-copy.c                 |  2 +-
block/file-posix.c                 |  2 +-
block/mirror.c                     |  8 ++++----
block/stream.c                     |  6 +++---
fsdev/9p-iov-marshal.c             | 15 ++++++++++++---
hw/block/virtio-blk.c              |  2 +-
hw/display/qxl.c                   |  4 ++--
hw/ide/ahci.c                      |  3 ++-
hw/scsi/vhost-scsi.c               |  2 +-
hw/sd/sdhci.c                      |  2 +-
hw/virtio/vhost-shadow-virtqueue.c |  6 ++++--
linux-user/hppa/cpu_loop.c         |  2 ++
migration/dirtyrate.c              |  4 ++--
migration/migration.c              |  2 +-
migration/ram.c                    |  2 +-
nbd/client-connection.c            |  2 +-
qom/object.c                       |  2 +-
target/loongarch/gdbstub.c         | 26 ++++++++++++++------------
tests/unit/test-bdrv-drain.c       |  2 +-
tests/unit/test-block-iothread.c   |  2 +-
util/qemu-coroutine.c              |  2 +-
util/qemu-timer.c                  |  6 +++---
roms/openbios                      |  2 +-
23 files changed, 61 insertions(+), 45 deletions(-)
[PULL 00/22] -Werror=maybe-uninitialized fixes
Posted by marcandre.lureau@redhat.com 1 year, 4 months ago 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855:

  Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100)

are available in the Git repository at:

  https://gitlab.com/marcandre.lureau/qemu.git tags/warn-pull-request

for you to fetch changes up to baad82ecfb27474f17f4318502725622ab7170fc:

  qom/object: fix -Werror=maybe-uninitialized (2024-10-02 11:36:12 +0400)

----------------------------------------------------------------
-Werror=maybe-uninitialized fixes

----------------------------------------------------------------

Marc-André Lureau (22):
  util/coroutine: fix -Werror=maybe-uninitialized false-positive
  util/timer: fix -Werror=maybe-uninitialized false-positive
  hw/qxl: fix -Werror=maybe-uninitialized false-positives
  nbd: fix -Werror=maybe-uninitialized false-positive
  block/mirror: fix -Werror=maybe-uninitialized false-positive
  block/mirror: fix -Werror=maybe-uninitialized false-positive
  block/stream: fix -Werror=maybe-uninitialized false-positives
  hw/ahci: fix -Werror=maybe-uninitialized false-positive
  hw/vhost-scsi: fix -Werror=maybe-uninitialized
  hw/sdhci: fix -Werror=maybe-uninitialized false-positive
  block/block-copy: fix -Werror=maybe-uninitialized false-positive
  migration: fix -Werror=maybe-uninitialized false-positives
  hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive
  migration: fix -Werror=maybe-uninitialized false-positive
  linux-user/hppa: fix -Werror=maybe-uninitialized false-positive
  target/loongarch: fix -Werror=maybe-uninitialized false-positive
  tests: fix -Werror=maybe-uninitialized false-positive
  hw/virtio: fix -Werror=maybe-uninitialized
  hw/virtio: freeing leaked memory from vhost_svq_get_buf in
    vhost_svq_poll
  block: fix -Werror=maybe-uninitialized false-positive
  fsdep/9p: fix -Werror=maybe-uninitialized false-positive
  qom/object: fix -Werror=maybe-uninitialized

 block/block-copy.c                 |  2 +-
 block/file-posix.c                 |  2 +-
 block/mirror.c                     |  8 ++++----
 block/stream.c                     |  6 +++---
 fsdev/9p-iov-marshal.c             | 15 ++++++++++++---
 hw/block/virtio-blk.c              |  2 +-
 hw/display/qxl.c                   |  4 ++--
 hw/ide/ahci.c                      |  3 ++-
 hw/scsi/vhost-scsi.c               |  2 +-
 hw/sd/sdhci.c                      |  2 +-
 hw/virtio/vhost-shadow-virtqueue.c |  6 ++++--
 linux-user/hppa/cpu_loop.c         |  2 ++
 migration/dirtyrate.c              |  4 ++--
 migration/migration.c              |  2 +-
 migration/ram.c                    |  2 +-
 nbd/client-connection.c            |  2 +-
 qom/object.c                       |  2 +-
 target/loongarch/gdbstub.c         | 26 ++++++++++++++------------
 tests/unit/test-bdrv-drain.c       |  2 +-
 tests/unit/test-block-iothread.c   |  2 +-
 util/qemu-coroutine.c              |  2 +-
 util/qemu-timer.c                  |  6 +++---
 roms/openbios                      |  2 +-
 23 files changed, 61 insertions(+), 45 deletions(-)

-- 
2.45.2.827.g557ae147e6
Re: [PULL 00/22] -Werror=maybe-uninitialized fixes
Posted by Thomas Huth 1 year, 4 months ago 
On 02/10/2024 10.36, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855:
> 
>    Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/marcandre.lureau/qemu.git tags/warn-pull-request
> 
> for you to fetch changes up to baad82ecfb27474f17f4318502725622ab7170fc:
> 
>    qom/object: fix -Werror=maybe-uninitialized (2024-10-02 11:36:12 +0400)
> 
> ----------------------------------------------------------------
> -Werror=maybe-uninitialized fixes
> 
> ----------------------------------------------------------------
> 
> Marc-André Lureau (22):
>    util/coroutine: fix -Werror=maybe-uninitialized false-positive
>    util/timer: fix -Werror=maybe-uninitialized false-positive
>    hw/qxl: fix -Werror=maybe-uninitialized false-positives
>    nbd: fix -Werror=maybe-uninitialized false-positive
>    block/mirror: fix -Werror=maybe-uninitialized false-positive
>    block/mirror: fix -Werror=maybe-uninitialized false-positive
>    block/stream: fix -Werror=maybe-uninitialized false-positives
>    hw/ahci: fix -Werror=maybe-uninitialized false-positive
>    hw/vhost-scsi: fix -Werror=maybe-uninitialized
>    hw/sdhci: fix -Werror=maybe-uninitialized false-positive
>    block/block-copy: fix -Werror=maybe-uninitialized false-positive
>    migration: fix -Werror=maybe-uninitialized false-positives
>    hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive
>    migration: fix -Werror=maybe-uninitialized false-positive
>    linux-user/hppa: fix -Werror=maybe-uninitialized false-positive
>    target/loongarch: fix -Werror=maybe-uninitialized false-positive
>    tests: fix -Werror=maybe-uninitialized false-positive
>    hw/virtio: fix -Werror=maybe-uninitialized
>    hw/virtio: freeing leaked memory from vhost_svq_get_buf in
>      vhost_svq_poll
>    block: fix -Werror=maybe-uninitialized false-positive
>    fsdep/9p: fix -Werror=maybe-uninitialized false-positive
>    qom/object: fix -Werror=maybe-uninitialized
> 
>   block/block-copy.c                 |  2 +-
>   block/file-posix.c                 |  2 +-
>   block/mirror.c                     |  8 ++++----
>   block/stream.c                     |  6 +++---
>   fsdev/9p-iov-marshal.c             | 15 ++++++++++++---
>   hw/block/virtio-blk.c              |  2 +-
>   hw/display/qxl.c                   |  4 ++--
>   hw/ide/ahci.c                      |  3 ++-
>   hw/scsi/vhost-scsi.c               |  2 +-
>   hw/sd/sdhci.c                      |  2 +-
>   hw/virtio/vhost-shadow-virtqueue.c |  6 ++++--
>   linux-user/hppa/cpu_loop.c         |  2 ++
>   migration/dirtyrate.c              |  4 ++--
>   migration/migration.c              |  2 +-
>   migration/ram.c                    |  2 +-
>   nbd/client-connection.c            |  2 +-
>   qom/object.c                       |  2 +-
>   target/loongarch/gdbstub.c         | 26 ++++++++++++++------------
>   tests/unit/test-bdrv-drain.c       |  2 +-
>   tests/unit/test-block-iothread.c   |  2 +-
>   util/qemu-coroutine.c              |  2 +-
>   util/qemu-timer.c                  |  6 +++---
>   roms/openbios                      |  2 +-

Replying here as well, so that Peter has a chance to see it:

The update to roms/openbios in patch 03 seems to have slipped in by 
accident, so I'd suggest to fix that first before merging this.

  Thomas
Re: [PULL 00/22] -Werror=maybe-uninitialized fixes
Posted by Marc-André Lureau 1 year, 4 months ago 
Hi

On Wed, Oct 2, 2024 at 12:43 PM Thomas Huth <thuth@redhat.com> wrote:

> On 02/10/2024 10.36, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The following changes since commit
> 718780d20470c66a3a36d036b29148d5809dc855:
> >
> >    Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu
> into staging (2024-10-01 11:34:07 +0100)
> >
> > are available in the Git repository at:
> >
> >    https://gitlab.com/marcandre.lureau/qemu.git tags/warn-pull-request
> >
> > for you to fetch changes up to baad82ecfb27474f17f4318502725622ab7170fc:
> >
> >    qom/object: fix -Werror=maybe-uninitialized (2024-10-02 11:36:12
> +0400)
> >
> > ----------------------------------------------------------------
> > -Werror=maybe-uninitialized fixes
> >
> > ----------------------------------------------------------------
> >
> > Marc-André Lureau (22):
> >    util/coroutine: fix -Werror=maybe-uninitialized false-positive
> >    util/timer: fix -Werror=maybe-uninitialized false-positive
> >    hw/qxl: fix -Werror=maybe-uninitialized false-positives
> >    nbd: fix -Werror=maybe-uninitialized false-positive
> >    block/mirror: fix -Werror=maybe-uninitialized false-positive
> >    block/mirror: fix -Werror=maybe-uninitialized false-positive
> >    block/stream: fix -Werror=maybe-uninitialized false-positives
> >    hw/ahci: fix -Werror=maybe-uninitialized false-positive
> >    hw/vhost-scsi: fix -Werror=maybe-uninitialized
> >    hw/sdhci: fix -Werror=maybe-uninitialized false-positive
> >    block/block-copy: fix -Werror=maybe-uninitialized false-positive
> >    migration: fix -Werror=maybe-uninitialized false-positives
> >    hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive
> >    migration: fix -Werror=maybe-uninitialized false-positive
> >    linux-user/hppa: fix -Werror=maybe-uninitialized false-positive
> >    target/loongarch: fix -Werror=maybe-uninitialized false-positive
> >    tests: fix -Werror=maybe-uninitialized false-positive
> >    hw/virtio: fix -Werror=maybe-uninitialized
> >    hw/virtio: freeing leaked memory from vhost_svq_get_buf in
> >      vhost_svq_poll
> >    block: fix -Werror=maybe-uninitialized false-positive
> >    fsdep/9p: fix -Werror=maybe-uninitialized false-positive
> >    qom/object: fix -Werror=maybe-uninitialized
> >
> >   block/block-copy.c                 |  2 +-
> >   block/file-posix.c                 |  2 +-
> >   block/mirror.c                     |  8 ++++----
> >   block/stream.c                     |  6 +++---
> >   fsdev/9p-iov-marshal.c             | 15 ++++++++++++---
> >   hw/block/virtio-blk.c              |  2 +-
> >   hw/display/qxl.c                   |  4 ++--
> >   hw/ide/ahci.c                      |  3 ++-
> >   hw/scsi/vhost-scsi.c               |  2 +-
> >   hw/sd/sdhci.c                      |  2 +-
> >   hw/virtio/vhost-shadow-virtqueue.c |  6 ++++--
> >   linux-user/hppa/cpu_loop.c         |  2 ++
> >   migration/dirtyrate.c              |  4 ++--
> >   migration/migration.c              |  2 +-
> >   migration/ram.c                    |  2 +-
> >   nbd/client-connection.c            |  2 +-
> >   qom/object.c                       |  2 +-
> >   target/loongarch/gdbstub.c         | 26 ++++++++++++++------------
> >   tests/unit/test-bdrv-drain.c       |  2 +-
> >   tests/unit/test-block-iothread.c   |  2 +-
> >   util/qemu-coroutine.c              |  2 +-
> >   util/qemu-timer.c                  |  6 +++---
> >   roms/openbios                      |  2 +-
>
> Replying here as well, so that Peter has a chance to see it:
>
> The update to roms/openbios in patch 03 seems to have slipped in by
> accident, so I'd suggest to fix that first before merging this.
>
>
\o/ submodules :)

Peter, do you want a v2?
thanks


-- 
Marc-André Lureau
Re: [PULL 00/22] -Werror=maybe-uninitialized fixes
Posted by Peter Maydell 1 year, 4 months ago 
On Wed, 2 Oct 2024 at 09:45, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Wed, Oct 2, 2024 at 12:43 PM Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 02/10/2024 10.36, marcandre.lureau@redhat.com wrote:
>> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
>> >
>> > The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855:
>> >
>> >    Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100)
>> >
>> > are available in the Git repository at:
>> >
>> >    https://gitlab.com/marcandre.lureau/qemu.git tags/warn-pull-request
>> >
>> > for you to fetch changes up to baad82ecfb27474f17f4318502725622ab7170fc:
>> >
>> >    qom/object: fix -Werror=maybe-uninitialized (2024-10-02 11:36:12 +0400)
>> >
>> > ----------------------------------------------------------------
>> > -Werror=maybe-uninitialized fixes
>> >
>> > ----------------------------------------------------------------
>> >
>> > Marc-André Lureau (22):
>> >    util/coroutine: fix -Werror=maybe-uninitialized false-positive
>> >    util/timer: fix -Werror=maybe-uninitialized false-positive
>> >    hw/qxl: fix -Werror=maybe-uninitialized false-positives
>> >    nbd: fix -Werror=maybe-uninitialized false-positive
>> >    block/mirror: fix -Werror=maybe-uninitialized false-positive
>> >    block/mirror: fix -Werror=maybe-uninitialized false-positive
>> >    block/stream: fix -Werror=maybe-uninitialized false-positives
>> >    hw/ahci: fix -Werror=maybe-uninitialized false-positive
>> >    hw/vhost-scsi: fix -Werror=maybe-uninitialized
>> >    hw/sdhci: fix -Werror=maybe-uninitialized false-positive
>> >    block/block-copy: fix -Werror=maybe-uninitialized false-positive
>> >    migration: fix -Werror=maybe-uninitialized false-positives
>> >    hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive
>> >    migration: fix -Werror=maybe-uninitialized false-positive
>> >    linux-user/hppa: fix -Werror=maybe-uninitialized false-positive
>> >    target/loongarch: fix -Werror=maybe-uninitialized false-positive
>> >    tests: fix -Werror=maybe-uninitialized false-positive
>> >    hw/virtio: fix -Werror=maybe-uninitialized
>> >    hw/virtio: freeing leaked memory from vhost_svq_get_buf in
>> >      vhost_svq_poll
>> >    block: fix -Werror=maybe-uninitialized false-positive
>> >    fsdep/9p: fix -Werror=maybe-uninitialized false-positive
>> >    qom/object: fix -Werror=maybe-uninitialized
>> >
>> >   block/block-copy.c                 |  2 +-
>> >   block/file-posix.c                 |  2 +-
>> >   block/mirror.c                     |  8 ++++----
>> >   block/stream.c                     |  6 +++---
>> >   fsdev/9p-iov-marshal.c             | 15 ++++++++++++---
>> >   hw/block/virtio-blk.c              |  2 +-
>> >   hw/display/qxl.c                   |  4 ++--
>> >   hw/ide/ahci.c                      |  3 ++-
>> >   hw/scsi/vhost-scsi.c               |  2 +-
>> >   hw/sd/sdhci.c                      |  2 +-
>> >   hw/virtio/vhost-shadow-virtqueue.c |  6 ++++--
>> >   linux-user/hppa/cpu_loop.c         |  2 ++
>> >   migration/dirtyrate.c              |  4 ++--
>> >   migration/migration.c              |  2 +-
>> >   migration/ram.c                    |  2 +-
>> >   nbd/client-connection.c            |  2 +-
>> >   qom/object.c                       |  2 +-
>> >   target/loongarch/gdbstub.c         | 26 ++++++++++++++------------
>> >   tests/unit/test-bdrv-drain.c       |  2 +-
>> >   tests/unit/test-block-iothread.c   |  2 +-
>> >   util/qemu-coroutine.c              |  2 +-
>> >   util/qemu-timer.c                  |  6 +++---
>> >   roms/openbios                      |  2 +-
>>
>> Replying here as well, so that Peter has a chance to see it:
>>
>> The update to roms/openbios in patch 03 seems to have slipped in by
>> accident, so I'd suggest to fix that first before merging this.
>>
>
> \o/ submodules :)
>
> Peter, do you want a v2?
> thanks

Yes, you'll need to resend the pullreq. (You can send just
the cover letter for a trivial tweak like this.)

-- PMM

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.