On 10/1/24 11:29, Harsh Prateek Bora wrote:
> Commit 1392617d3576 intended to tag pseries-2.1 - 2.11 machines as
> deprecated with reasons mentioned in its commit log.
> Removing pseries-2.3 specific code with this patch for now.
>
> Suggested-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> ---
> hw/ppc/spapr.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 3c7d251356..f2f20aa5b5 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -5349,21 +5349,6 @@ static void spapr_machine_2_4_class_options(MachineClass *mc)
>
> DEFINE_SPAPR_MACHINE(2, 4);
>
> -/*
> - * pseries-2.3
> - */
> -
> -static void spapr_machine_2_3_class_options(MachineClass *mc)
> -{
> - static GlobalProperty compat[] = {
> - { "spapr-pci-host-bridge", "dynamic-reconfiguration", "off" },
Shouldn't we remove SpaprPhbState::dr_enabled also ?
Thanks,
C.
> - };
> - spapr_machine_2_4_class_options(mc);
> - compat_props_add(mc->compat_props, hw_compat_2_3, hw_compat_2_3_len);
> - compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat));
> -}
> -DEFINE_SPAPR_MACHINE(2, 3);
> -
> static void spapr_machine_register_types(void)
> {
> type_register_static(&spapr_machine_info);