On 9/30/24 00:34, Philippe Mathieu-Daudé wrote:
> Define both endianness variants with a single macro.
> Useful to add yet other endian specific definitions
> in the next commit.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/pci/pci_device.h | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/include/hw/pci/pci_device.h b/include/hw/pci/pci_device.h
> index 91df40f989..ff619241a4 100644
> --- a/include/hw/pci/pci_device.h
> +++ b/include/hw/pci/pci_device.h
> @@ -298,13 +298,14 @@ static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr,
> return st##_s##_dma(pci_get_address_space(dev), addr, val, attrs); \
> }
>
> +#define PCI_DMA_DEFINE_LDST_END(_l, _s, _bits) \
> + PCI_DMA_DEFINE_LDST(_l##_le, _s##_le, _bits) \
> + PCI_DMA_DEFINE_LDST(_l##_be, _s##_be, _bits)
> +
> PCI_DMA_DEFINE_LDST(ub, b, 8);
> -PCI_DMA_DEFINE_LDST(uw_le, w_le, 16)
> -PCI_DMA_DEFINE_LDST(l_le, l_le, 32);
> -PCI_DMA_DEFINE_LDST(q_le, q_le, 64);
> -PCI_DMA_DEFINE_LDST(uw_be, w_be, 16)
> -PCI_DMA_DEFINE_LDST(l_be, l_be, 32);
> -PCI_DMA_DEFINE_LDST(q_be, q_be, 64);
> +PCI_DMA_DEFINE_LDST_END(uw, w, 16)
> +PCI_DMA_DEFINE_LDST_END(l, l, 32)
> +PCI_DMA_DEFINE_LDST_END(q, q, 64)
>
> #undef PCI_DMA_DEFINE_LDST
>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>