[v2] kvm: Improve register failure reports for migration

[PATCH v2 0/2] kvm: Improve register failure reports for migration

Julia Suvorova posted 2 patches 1 year, 4 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240927104743.218468-1-jusual@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Marcelo Tosatti <mtosatti@redhat.com>, Song Gao <gaosong@loongson.cn>, Huacai Chen <chenhuacai@kernel.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>

accel/kvm/kvm-all.c        | 41 +++++++++++++++++++++++++++++---------
include/sysemu/kvm.h       |  4 ++--
target/arm/kvm.c           |  4 ++--
target/i386/kvm/kvm.c      | 27 +++++++++++++++++++++++--
target/loongarch/kvm/kvm.c |  4 ++--
target/mips/kvm.c          |  4 ++--
target/ppc/kvm.c           |  2 +-
target/riscv/kvm/kvm-cpu.c |  4 ++--
target/s390x/kvm/kvm.c     |  4 ++--
9 files changed, 70 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH v2 0/2] kvm: Improve register failure reports for migration

Posted by Julia Suvorova 1 year, 4 months ago

There were a few bugs with silent cpu failures during migrations [1].
The failures are no longer silent thanks to [2], but still
indistinguishable, making diagnostics difficult.

This patchset reworks kvm_arch_get/put_registers to handle Error** and
return a correct message, with x86_64 as a start.

[1] https://issues.redhat.com/browse/RHEL-7558
[2] 7191f24c7fcf "accel/kvm/kvm-all: Handle register access errors"

--
v2:
    * made all reports as error_reportf_err() and fixed prefixes [Peter]

Julia Suvorova (2):
  kvm: Allow kvm_arch_get/put_registers to accept Error**
  target/i386/kvm: Report which action failed in
    kvm_arch_put/get_registers

 accel/kvm/kvm-all.c        | 41 +++++++++++++++++++++++++++++---------
 include/sysemu/kvm.h       |  4 ++--
 target/arm/kvm.c           |  4 ++--
 target/i386/kvm/kvm.c      | 27 +++++++++++++++++++++++--
 target/loongarch/kvm/kvm.c |  4 ++--
 target/mips/kvm.c          |  4 ++--
 target/ppc/kvm.c           |  2 +-
 target/riscv/kvm/kvm-cpu.c |  4 ++--
 target/s390x/kvm/kvm.c     |  4 ++--
 9 files changed, 70 insertions(+), 24 deletions(-)

-- 
2.45.0

Re: [PATCH v2 0/2] kvm: Improve register failure reports for migration

Posted by Paolo Bonzini 1 year, 4 months ago

Queued, thanks.

Paolo