hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header

[PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header

Posted by Philippe Mathieu-Daudé 3 weeks, 5 days ago

We were including the "exec/tswap.h" header to get
target_words_bigendian() declaration, but since commit a276ec8e26
("hw/audio/virtio-snd: Always use little endian audio format")
removed this method call, we don't need this header anymore.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/audio/virtio-snd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
index 69838181dd..c5581d7b3d 100644
--- a/hw/audio/virtio-snd.c
+++ b/hw/audio/virtio-snd.c
@@ -20,7 +20,6 @@
 #include "qemu/log.h"
 #include "qemu/error-report.h"
 #include "qemu/lockable.h"
-#include "exec/tswap.h"
 #include "sysemu/runstate.h"
 #include "trace.h"
 #include "qapi/error.h"
-- 
2.45.2

Re: [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header

Posted by Richard Henderson 2 weeks, 5 days ago

On 9/26/24 03:21, Philippe Mathieu-Daudé wrote:
> We were including the "exec/tswap.h" header to get
> target_words_bigendian() declaration, but since commit a276ec8e26
> ("hw/audio/virtio-snd: Always use little endian audio format")
> removed this method call, we don't need this header anymore.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/audio/virtio-snd.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] hw/audio/virtio-snd: Remove unnecessary "exec/tswap.h" header

Posted by Manos Pitsidianakis 3 weeks, 5 days ago

On Thu, 26 Sep 2024 13:21, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>We were including the "exec/tswap.h" header to get
>target_words_bigendian() declaration, but since commit a276ec8e26
>("hw/audio/virtio-snd: Always use little endian audio format")
>removed this method call, we don't need this header anymore.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>---
> hw/audio/virtio-snd.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
>index 69838181dd..c5581d7b3d 100644
>--- a/hw/audio/virtio-snd.c
>+++ b/hw/audio/virtio-snd.c
>@@ -20,7 +20,6 @@
> #include "qemu/log.h"
> #include "qemu/error-report.h"
> #include "qemu/lockable.h"
>-#include "exec/tswap.h"
> #include "sysemu/runstate.h"
> #include "trace.h"
> #include "qapi/error.h"
>-- 
>2.45.2
>

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>