On Tue, 24 Sep 2024 16:05, marcandre.lureau@redhat.com wrote:
>From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>../hw/ide/ahci.c:989:58: error: ‘tbl_entry_size’ may be used uninitialized [-Werror=maybe-uninitialized]
>
>Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>---
> hw/ide/ahci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
>index 7fc2a08df2..d700986c39 100644
>--- a/hw/ide/ahci.c
>+++ b/hw/ide/ahci.c
>@@ -948,7 +948,6 @@ static int ahci_populate_sglist(AHCIDevice *ad, QEMUSGList *sglist,
> uint64_t sum = 0;
> int off_idx = -1;
> int64_t off_pos = -1;
>- int tbl_entry_size;
> IDEBus *bus = &ad->port;
> BusState *qbus = BUS(bus);
>
>@@ -976,6 +975,8 @@ static int ahci_populate_sglist(AHCIDevice *ad, QEMUSGList *sglist,
> /* Get entries in the PRDT, init a qemu sglist accordingly */
> if (prdtl > 0) {
> AHCI_SG *tbl = (AHCI_SG *)prdt;
>+ int tbl_entry_size = -1;
>+
Semantically it should be 0 instead of -1.
Either way:
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> sum = 0;
> for (i = 0; i < prdtl; i++) {
> tbl_entry_size = prdt_tbl_entry_size(&tbl[i]);
>--
>2.45.2.827.g557ae147e6
>
>