[v2] -Werror=maybe-uninitialized fixes

[PATCH v2 03/22] hw/qxl: fix -Werror=maybe-uninitialized false-positives

Posted by marcandre.lureau@redhat.com 4 weeks ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

../hw/display/qxl.c:1352:5: error: ‘pci_region’ may be used uninitialized [-Werror=maybe-uninitialized]
../hw/display/qxl.c:1365:22: error: ‘pci_start’ may be used uninitialized [-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/display/qxl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 3c2b5182ca..20e13ee98d 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -1301,8 +1301,8 @@ static int qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta,
     };
     uint64_t guest_start;
     uint64_t guest_end;
-    int pci_region;
-    pcibus_t pci_start;
+    int pci_region = -1;
+    pcibus_t pci_start = -1;
     pcibus_t pci_end;
     MemoryRegion *mr;
     intptr_t virt_start;
-- 
2.45.2.827.g557ae147e6

Re: [PATCH v2 03/22] hw/qxl: fix -Werror=maybe-uninitialized false-positives

Posted by Manos Pitsidianakis 3 weeks, 5 days ago

On Tue, 24 Sep 2024 16:05, marcandre.lureau@redhat.com wrote:
>From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>../hw/display/qxl.c:1352:5: error: ‘pci_region’ may be used uninitialized [-Werror=maybe-uninitialized]
>../hw/display/qxl.c:1365:22: error: ‘pci_start’ may be used uninitialized [-Werror=maybe-uninitialized]
>
>Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>---
> hw/display/qxl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/hw/display/qxl.c b/hw/display/qxl.c
>index 3c2b5182ca..20e13ee98d 100644
>--- a/hw/display/qxl.c
>+++ b/hw/display/qxl.c
>@@ -1301,8 +1301,8 @@ static int qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta,
>     };
>     uint64_t guest_start;
>     uint64_t guest_end;
>-    int pci_region;
>-    pcibus_t pci_start;
>+    int pci_region = -1;
>+    pcibus_t pci_start = -1;

Suggestion:

-    pcibus_t pci_start;
+    pcibus_t pci_start = PCI_BAR_UNMAPPED;

Either way,

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

>     pcibus_t pci_end;
>     MemoryRegion *mr;
>     intptr_t virt_start;
>-- 
>2.45.2.827.g557ae147e6
>
>