Hi,
Seems there are more confusing option descriptions like:
+ printf "%s\n" ' --disable-install-blobs install provided firmware
blobs'
...
+ printf "%s\n" ' --disable-coroutine-pool coroutine freelist (better
performance)'
Should we change them ?
Thanks,
Aditya Gupta
On 23/09/24 12:26, Aditya Gupta wrote:
> The existing description of '--disable-debug-info' seems to have a typo.
>
> Later scripts/meson-buildoptions.sh does the following based on option:
>
> + --enable-debug-info) printf "%s" -Ddebug=true ;;
> + --disable-debug-info) printf "%s" -Ddebug=false ;;
>
> With above logic, the description should be 'Disable debug symbols...'
> instead of 'Enable debug symbols...', Fix the typo by replacing Enable
> with Disable.
>
> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
> ---
> scripts/meson-buildoptions.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh
> index cfadb5ea86af..81c053a0fffa 100644
> --- a/scripts/meson-buildoptions.sh
> +++ b/scripts/meson-buildoptions.sh
> @@ -12,7 +12,7 @@ meson_options_help() {
> printf "%s\n" ' affects only QEMU, not tools like qemu-img)'
> printf "%s\n" ' --datadir=VALUE Data file directory [share]'
> printf "%s\n" ' --disable-coroutine-pool coroutine freelist (better performance)'
> - printf "%s\n" ' --disable-debug-info Enable debug symbols and other information'
> + printf "%s\n" ' --disable-debug-info Disable debug symbols and other information'
> printf "%s\n" ' --disable-hexagon-idef-parser'
> printf "%s\n" ' use idef-parser to automatically generate TCG'
> printf "%s\n" ' code for the Hexagon frontend'