replay: Remove unused replay_disable_events

[PATCH] replay: Remove unused replay_disable_events

Posted by dave@treblig.org 1 month ago

From: "Dr. David Alan Gilbert" <dave@treblig.org>

replay_disable_events has been unused since 2019's
  c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
 include/sysemu/replay.h | 2 --
 replay/replay-events.c  | 9 ---------
 2 files changed, 11 deletions(-)

diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
index 8102fa54f0..cba74fa9bc 100644
--- a/include/sysemu/replay.h
+++ b/include/sysemu/replay.h
@@ -117,8 +117,6 @@ void replay_async_events(void);
 
 /* Asynchronous events queue */
 
-/*! Disables storing events in the queue */
-void replay_disable_events(void);
 /*! Enables storing events in the queue */
 void replay_enable_events(void);
 /*! Returns true when saving events is enabled */
diff --git a/replay/replay-events.c b/replay/replay-events.c
index af0721cc1a..2e46eda6bf 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -92,15 +92,6 @@ void replay_flush_events(void)
     }
 }
 
-void replay_disable_events(void)
-{
-    if (replay_mode != REPLAY_MODE_NONE) {
-        events_enabled = false;
-        /* Flush events queue before waiting of completion */
-        replay_flush_events();
-    }
-}
-
 /*! Adds specified async event to the queue */
 void replay_add_event(ReplayAsyncEventKind event_kind,
                       void *opaque,
-- 
2.46.0

Re: [PATCH] replay: Remove unused replay_disable_events

Posted by Thomas Huth 2 weeks, 6 days ago

On 19/09/2024 01.40, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
> 
> replay_disable_events has been unused since 2019's
>    c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
>   include/sysemu/replay.h | 2 --
>   replay/replay-events.c  | 9 ---------
>   2 files changed, 11 deletions(-)
> 
> diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
> index 8102fa54f0..cba74fa9bc 100644
> --- a/include/sysemu/replay.h
> +++ b/include/sysemu/replay.h
> @@ -117,8 +117,6 @@ void replay_async_events(void);
>   
>   /* Asynchronous events queue */
>   
> -/*! Disables storing events in the queue */
> -void replay_disable_events(void);
>   /*! Enables storing events in the queue */
>   void replay_enable_events(void);
>   /*! Returns true when saving events is enabled */
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index af0721cc1a..2e46eda6bf 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -92,15 +92,6 @@ void replay_flush_events(void)
>       }
>   }
>   
> -void replay_disable_events(void)
> -{
> -    if (replay_mode != REPLAY_MODE_NONE) {
> -        events_enabled = false;
> -        /* Flush events queue before waiting of completion */
> -        replay_flush_events();
> -    }
> -}
> -
>   /*! Adds specified async event to the queue */
>   void replay_add_event(ReplayAsyncEventKind event_kind,
>                         void *opaque,

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] replay: Remove unused replay_disable_events

Posted by Pavel Dovgalyuk 1 month ago

Reviewed-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>

On 19.09.2024 02:40, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
> 
> replay_disable_events has been unused since 2019's
>    c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
>   include/sysemu/replay.h | 2 --
>   replay/replay-events.c  | 9 ---------
>   2 files changed, 11 deletions(-)
> 
> diff --git a/include/sysemu/replay.h b/include/sysemu/replay.h
> index 8102fa54f0..cba74fa9bc 100644
> --- a/include/sysemu/replay.h
> +++ b/include/sysemu/replay.h
> @@ -117,8 +117,6 @@ void replay_async_events(void);
>   
>   /* Asynchronous events queue */
>   
> -/*! Disables storing events in the queue */
> -void replay_disable_events(void);
>   /*! Enables storing events in the queue */
>   void replay_enable_events(void);
>   /*! Returns true when saving events is enabled */
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index af0721cc1a..2e46eda6bf 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -92,15 +92,6 @@ void replay_flush_events(void)
>       }
>   }
>   
> -void replay_disable_events(void)
> -{
> -    if (replay_mode != REPLAY_MODE_NONE) {
> -        events_enabled = false;
> -        /* Flush events queue before waiting of completion */
> -        replay_flush_events();
> -    }
> -}
> -
>   /*! Adds specified async event to the queue */
>   void replay_add_event(ReplayAsyncEventKind event_kind,
>                         void *opaque,