qemu-timer: Remove unused qemu_clock_get_main_loop_timerlist

[PATCH] qemu-timer: Remove unused qemu_clock_get_main_loop_timerlist

Posted by dave@treblig.org 2 months ago

From: "Dr. David Alan Gilbert" <dave@treblig.org>

qemu_clock_get_main_loop_timerlist has been unused since it was
originally added in
  ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
 include/qemu/timer.h | 10 ----------
 util/qemu-timer.c    |  5 -----
 2 files changed, 15 deletions(-)

diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index fa56ec9481..ccd8578ae3 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -190,16 +190,6 @@ bool qemu_clock_use_for_deadline(QEMUClockType type);
  */
 int64_t qemu_clock_deadline_ns_all(QEMUClockType type, int attr_mask);
 
-/**
- * qemu_clock_get_main_loop_timerlist:
- * @type: the clock type
- *
- * Return the default timer list associated with a clock.
- *
- * Returns: the default timer list
- */
-QEMUTimerList *qemu_clock_get_main_loop_timerlist(QEMUClockType type);
-
 /**
  * qemu_clock_nofify:
  * @type: the clock type
diff --git a/util/qemu-timer.c b/util/qemu-timer.c
index 213114be68..e5b5452e4e 100644
--- a/util/qemu-timer.c
+++ b/util/qemu-timer.c
@@ -291,11 +291,6 @@ QEMUClockType timerlist_get_clock(QEMUTimerList *timer_list)
     return timer_list->clock->type;
 }
 
-QEMUTimerList *qemu_clock_get_main_loop_timerlist(QEMUClockType type)
-{
-    return main_loop_tlg.tl[type];
-}
-
 void timerlist_notify(QEMUTimerList *timer_list)
 {
     if (timer_list->notify_cb) {
-- 
2.46.0

Re: [PATCH] qemu-timer: Remove unused qemu_clock_get_main_loop_timerlist

Posted by Dr. David Alan Gilbert 2 months ago

* dave@treblig.org (dave@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
> 
> qemu_clock_get_main_loop_timerlist has been unused since it was
> originally added in
>   ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>

V2 sent, see:

[PATCH v2] qemu-timer: Remove unused timer functions
<20240919144124.309646-1-dave@treblig.org>

I found another one.

Dave

> ---
>  include/qemu/timer.h | 10 ----------
>  util/qemu-timer.c    |  5 -----
>  2 files changed, 15 deletions(-)
> 
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index fa56ec9481..ccd8578ae3 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -190,16 +190,6 @@ bool qemu_clock_use_for_deadline(QEMUClockType type);
>   */
>  int64_t qemu_clock_deadline_ns_all(QEMUClockType type, int attr_mask);
>  
> -/**
> - * qemu_clock_get_main_loop_timerlist:
> - * @type: the clock type
> - *
> - * Return the default timer list associated with a clock.
> - *
> - * Returns: the default timer list
> - */
> -QEMUTimerList *qemu_clock_get_main_loop_timerlist(QEMUClockType type);
> -
>  /**
>   * qemu_clock_nofify:
>   * @type: the clock type
> diff --git a/util/qemu-timer.c b/util/qemu-timer.c
> index 213114be68..e5b5452e4e 100644
> --- a/util/qemu-timer.c
> +++ b/util/qemu-timer.c
> @@ -291,11 +291,6 @@ QEMUClockType timerlist_get_clock(QEMUTimerList *timer_list)
>      return timer_list->clock->type;
>  }
>  
> -QEMUTimerList *qemu_clock_get_main_loop_timerlist(QEMUClockType type)
> -{
> -    return main_loop_tlg.tl[type];
> -}
> -
>  void timerlist_notify(QEMUTimerList *timer_list)
>  {
>      if (timer_list->notify_cb) {
> -- 
> 2.46.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/