tests/qemu-iotests/testenv: Use the "virt" machine for or1k

[PATCH] tests/qemu-iotests/testenv: Use the "virt" machine for or1k

Thomas Huth posted 1 patch 1 year, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240917193028.320400-1-thuth@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

tests/qemu-iotests/testenv.py | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] tests/qemu-iotests/testenv: Use the "virt" machine for or1k

Posted by Thomas Huth 1 year, 2 months ago

When compiling QEMU just with "--target-list=or1k-softmmu", there
are 8 iotests failing that try to use PCI devices - but the default
or1k machine does not have a PCI bus. The "virt" machine is better
suited for running the iotests than the or1k default machine since
it provides PCI and thus e.g. support for virtio-blk and virtio-scsi,
too. With this change, there are no failing iotests anymore when
using the qemu-system-or1k binary for running the tests.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/testenv.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index c8848f2ec2..0b32eec119 100644
--- a/tests/qemu-iotests/testenv.py
+++ b/tests/qemu-iotests/testenv.py
@@ -240,6 +240,7 @@ def __init__(self, source_dir: str, build_dir: str,
             ('aarch64', 'virt'),
             ('avr', 'mega2560'),
             ('m68k', 'virt'),
+            ('or1k', 'virt'),
             ('riscv32', 'virt'),
             ('riscv64', 'virt'),
             ('rx', 'gdbsim-r5f562n8'),
-- 
2.46.0

Re: [PATCH] tests/qemu-iotests/testenv: Use the "virt" machine for or1k

Posted by Richard Henderson 1 year, 2 months ago

On 9/17/24 21:30, Thomas Huth wrote:
> When compiling QEMU just with "--target-list=or1k-softmmu", there
> are 8 iotests failing that try to use PCI devices - but the default
> or1k machine does not have a PCI bus. The "virt" machine is better
> suited for running the iotests than the or1k default machine since
> it provides PCI and thus e.g. support for virtio-blk and virtio-scsi,
> too. With this change, there are no failing iotests anymore when
> using the qemu-system-or1k binary for running the tests.
> 
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
>   tests/qemu-iotests/testenv.py | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~