tests/unit: Really build pbkdf test on macOS

[PATCH] tests/unit: Really build pbkdf test on macOS

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

Fix a typo to run the pbkdf crypto cipher tests on macOS.

 $ make check-unit
   ...
   87/102 qemu:unit / test-crypto-pbkdf      OK      2.35s   17 subtests passed

Fixes: ebe0302ac8 ("tests/unit: build pbkdf test on macOS")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/unit/test-crypto-pbkdf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit/test-crypto-pbkdf.c b/tests/unit/test-crypto-pbkdf.c
index b477cf4e4b..12ee808fbc 100644
--- a/tests/unit/test-crypto-pbkdf.c
+++ b/tests/unit/test-crypto-pbkdf.c
@@ -25,7 +25,7 @@
 #include <sys/resource.h>
 #endif
 
-#if defined(_WIN32) || defined(RUSAGE_THREAD) || defined(CONFIG_DARWNI)
+#if defined(_WIN32) || defined(RUSAGE_THREAD) || defined(CONFIG_DARWIN)
 #include "crypto/pbkdf.h"
 
 typedef struct QCryptoPbkdfTestData QCryptoPbkdfTestData;
-- 
2.45.2

Re: [PATCH] tests/unit: Really build pbkdf test on macOS

Posted by Daniel P. Berrangé 1 year, 2 months ago

On Tue, Sep 17, 2024 at 08:57:36AM +0200, Philippe Mathieu-Daudé wrote:
> Fix a typo to run the pbkdf crypto cipher tests on macOS.
> 
>  $ make check-unit
>    ...
>    87/102 qemu:unit / test-crypto-pbkdf      OK      2.35s   17 subtests passed
> 
> Fixes: ebe0302ac8 ("tests/unit: build pbkdf test on macOS")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  tests/unit/test-crypto-pbkdf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/unit/test-crypto-pbkdf.c b/tests/unit/test-crypto-pbkdf.c
> index b477cf4e4b..12ee808fbc 100644
> --- a/tests/unit/test-crypto-pbkdf.c
> +++ b/tests/unit/test-crypto-pbkdf.c
> @@ -25,7 +25,7 @@
>  #include <sys/resource.h>
>  #endif
>  
> -#if defined(_WIN32) || defined(RUSAGE_THREAD) || defined(CONFIG_DARWNI)
> +#if defined(_WIN32) || defined(RUSAGE_THREAD) || defined(CONFIG_DARWIN)

/face-palm

>  #include "crypto/pbkdf.h"
>  
>  typedef struct QCryptoPbkdfTestData QCryptoPbkdfTestData;

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] tests/unit: Really build pbkdf test on macOS

Posted by Michael Tokarev 1 year, 2 months ago

On 17.09.2024 11:20, Daniel P. Berrangé wrote:
> On Tue, Sep 17, 2024 at 08:57:36AM +0200, Philippe Mathieu-Daudé wrote:
>> Fix a typo to run the pbkdf crypto cipher tests on macOS.
>>
>>   $ make check-unit
>>     ...
>>     87/102 qemu:unit / test-crypto-pbkdf      OK      2.35s   17 subtests passed
>>
>> Fixes: ebe0302ac8 ("tests/unit: build pbkdf test on macOS")

Picked up for trivial-patches tree, thanks!

/mjt