[v1] virtio-net fixes

[PATCH 0/7] virtio-net fixes

Posted by Akihiko Odaki 2 months, 1 week ago

Most of this series are fixes for software RSS and hash reporting, which
should have no production user.

However there is one exception; patch "virtio-net: Fix size check in
dhclient workaround" fixes an out-of-bound access that can be triggered
for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and
can be applied independently.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Akihiko Odaki (7):
      net: checksum: Convert data to void *
      virtio-net: Fix size check in dhclient workaround
      virtio-net: Do not check for the queue before RSS
      virtio-net: Fix hash reporting when the queue changes
      virtio-net: Initialize hash reporting values
      virtio-net: Copy received header to buffer
      virtio-net: Fix num_buffers for version 1

 include/net/checksum.h |   2 +-
 hw/net/virtio-net.c    | 109 ++++++++++++++++++++++++++++---------------------
 net/checksum.c         |   4 +-
 3 files changed, 65 insertions(+), 50 deletions(-)
---
base-commit: 31669121a01a14732f57c49400bc239cf9fd505f
change-id: 20240907-queue-f425937a730f

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>

Re: [PATCH 0/7] virtio-net fixes

Posted by Michael Tokarev 1 month, 1 week ago

On 15.09.2024 04:06, Akihiko Odaki wrote:
> Most of this series are fixes for software RSS and hash reporting, which
> should have no production user.
> 
> However there is one exception; patch "virtio-net: Fix size check in
> dhclient workaround" fixes an out-of-bound access that can be triggered
> for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and
> can be applied independently.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Akihiko Odaki (7):
>        net: checksum: Convert data to void *
>        virtio-net: Fix size check in dhclient workaround
>        virtio-net: Do not check for the queue before RSS
>        virtio-net: Fix hash reporting when the queue changes
>        virtio-net: Initialize hash reporting values
>        virtio-net: Copy received header to buffer
>        virtio-net: Fix num_buffers for version 1
> 
>   include/net/checksum.h |   2 +-
>   hw/net/virtio-net.c    | 109 ++++++++++++++++++++++++++++---------------------
>   net/checksum.c         |   4 +-
>   3 files changed, 65 insertions(+), 50 deletions(-)

Hi!

Has this patchset been forgotten, or does it wait for some
R-b's ?

Thanks,

/mjt

Re: [PATCH 0/7] virtio-net fixes

Posted by Jason Wang 1 month, 1 week ago

Hi Michael:

On Wed, Oct 16, 2024 at 1:58 AM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> On 15.09.2024 04:06, Akihiko Odaki wrote:
> > Most of this series are fixes for software RSS and hash reporting, which
> > should have no production user.
> >
> > However there is one exception; patch "virtio-net: Fix size check in
> > dhclient workaround" fixes an out-of-bound access that can be triggered
> > for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and
> > can be applied independently.
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> > ---
> > Akihiko Odaki (7):
> >        net: checksum: Convert data to void *
> >        virtio-net: Fix size check in dhclient workaround
> >        virtio-net: Do not check for the queue before RSS
> >        virtio-net: Fix hash reporting when the queue changes
> >        virtio-net: Initialize hash reporting values
> >        virtio-net: Copy received header to buffer
> >        virtio-net: Fix num_buffers for version 1
> >
> >   include/net/checksum.h |   2 +-
> >   hw/net/virtio-net.c    | 109 ++++++++++++++++++++++++++++---------------------
> >   net/checksum.c         |   4 +-
> >   3 files changed, 65 insertions(+), 50 deletions(-)
>
> Hi!
>
> Has this patchset been forgotten, or does it wait for some
> R-b's ?

Thanks for the reminder.

I would go through this series.

Thanks

>
> Thanks,
>
> /mjt
>