hw/loongarch/virt: Add description for virt machine type

[PATCH] hw/loongarch/virt: Add description for virt machine type

Posted by Bibo Mao 1 year, 4 months ago

The description about virt machine type is removed by mistake, add
new description here. Here is output result with command
"./qemu-system-loongarch64 -M help"

Supported machines are:
none                 empty machine
virt                 QEMU LoongArch Virtual Machine (default)
x-remote             Experimental remote machine

Without the patch, it shows as follows:
Supported machines are:
none                 empty machine
virt                 (null) (default)
x-remote             Experimental remote machine

Fixes: ef2f11454c(hw/loongarch/virt: Replace Loongson IPI with LoongArch IPI)
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
 hw/loongarch/virt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
index 29040422aa..8e80110b24 100644
--- a/hw/loongarch/virt.c
+++ b/hw/loongarch/virt.c
@@ -1390,6 +1390,7 @@ static void virt_class_init(ObjectClass *oc, void *data)
     mc->init = virt_init;
     mc->default_cpu_type = LOONGARCH_CPU_TYPE_NAME("la464");
     mc->default_ram_id = "loongarch.ram";
+    mc->desc = "QEMU LoongArch Virtual Machine";
     mc->max_cpus = LOONGARCH_MAX_CPUS;
     mc->is_default = 1;
     mc->default_kernel_irqchip_split = false;

base-commit: 4b7ea33074450bc6148c8e1545d78f179e64adb4
-- 
2.39.3

Re: [PATCH] hw/loongarch/virt: Add description for virt machine type

Posted by Michael Tokarev 1 year, 4 months ago

On 13.09.2024 12:52, Bibo Mao wrote:
> The description about virt machine type is removed by mistake, add
> new description here. Here is output result with command
> "./qemu-system-loongarch64 -M help"
> 
> Supported machines are:
> none                 empty machine
> virt                 QEMU LoongArch Virtual Machine (default)
> x-remote             Experimental remote machine
> 
> Without the patch, it shows as follows:
> Supported machines are:
> none                 empty machine
> virt                 (null) (default)
> x-remote             Experimental remote machine
> 
> Fixes: ef2f11454c(hw/loongarch/virt: Replace Loongson IPI with LoongArch IPI)

Applied to my trivial-patches tree, thanks!

/mjt

Re: [PATCH] hw/loongarch/virt: Add description for virt machine type

Posted by Thomas Huth 1 year, 4 months ago

On 13/09/2024 11.52, Bibo Mao wrote:
> The description about virt machine type is removed by mistake, add
> new description here. Here is output result with command
> "./qemu-system-loongarch64 -M help"
> 
> Supported machines are:
> none                 empty machine
> virt                 QEMU LoongArch Virtual Machine (default)
> x-remote             Experimental remote machine
> 
> Without the patch, it shows as follows:
> Supported machines are:
> none                 empty machine
> virt                 (null) (default)
> x-remote             Experimental remote machine
> 
> Fixes: ef2f11454c(hw/loongarch/virt: Replace Loongson IPI with LoongArch IPI)
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>   hw/loongarch/virt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
> index 29040422aa..8e80110b24 100644
> --- a/hw/loongarch/virt.c
> +++ b/hw/loongarch/virt.c
> @@ -1390,6 +1390,7 @@ static void virt_class_init(ObjectClass *oc, void *data)
>       mc->init = virt_init;
>       mc->default_cpu_type = LOONGARCH_CPU_TYPE_NAME("la464");
>       mc->default_ram_id = "loongarch.ram";
> +    mc->desc = "QEMU LoongArch Virtual Machine";
>       mc->max_cpus = LOONGARCH_MAX_CPUS;
>       mc->is_default = 1;
>       mc->default_kernel_irqchip_split = false;
> 
> base-commit: 4b7ea33074450bc6148c8e1545d78f179e64adb4

Reviewed-by: Thomas Huth <thuth@redhat.com>

CC:-ing qemu-stable for getting it fixed in the next stable release of 9.1, too.