[v1] Use g_assert_not_reached instead of (g_)assert(0, false)

[PATCH 04/39] hw/char: replace assert(0) with g_assert_not_reached()

Posted by Pierrick Bouvier 2 months, 2 weeks ago

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 hw/char/avr_usart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/char/avr_usart.c b/hw/char/avr_usart.c
index 5bcf9db0b78..e738a2ca97e 100644
--- a/hw/char/avr_usart.c
+++ b/hw/char/avr_usart.c
@@ -86,7 +86,7 @@ static void update_char_mask(AVRUsartState *usart)
         usart->char_mask = 0b11111111;
         break;
     default:
-        assert(0);
+        g_assert_not_reached();
     }
 }
 
-- 
2.39.2

Re: [PATCH 04/39] hw/char: replace assert(0) with g_assert_not_reached()

Posted by Philippe Mathieu-Daudé 2 months, 2 weeks ago

On 11/9/24 00:15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/char/avr_usart.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 04/39] hw/char: replace assert(0) with g_assert_not_reached()

Posted by Richard Henderson 2 months, 2 weeks ago

On 9/10/24 15:15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/char/avr_usart.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/char/avr_usart.c b/hw/char/avr_usart.c
> index 5bcf9db0b78..e738a2ca97e 100644
> --- a/hw/char/avr_usart.c
> +++ b/hw/char/avr_usart.c
> @@ -86,7 +86,7 @@ static void update_char_mask(AVRUsartState *usart)
>           usart->char_mask = 0b11111111;
>           break;
>       default:
> -        assert(0);
> +        g_assert_not_reached();
>       }
>   }
>   

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~