[v1] Use g_assert_not_reached instead of (g_)assert(0, false)

[PATCH 39/39] scripts/checkpatch.pl: emit error when using assert(false)

Posted by Pierrick Bouvier 2 months, 2 weeks ago

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 scripts/checkpatch.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 65b6f46f905..fa9c12230eb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3102,6 +3102,9 @@ sub process {
 		if ($line =~ /\b(g_)?assert\(0\)/) {
 			ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr);
 		}
+		if ($line =~ /\b(g_)?assert\(false\)/) {
+			ERROR("use g_assert_not_reached() instead of assert(false)\n" . $herecurr);
+		}
 		if ($line =~ /\bstrerrorname_np\(/) {
 			ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);
 		}
-- 
2.39.2

Re: [PATCH 39/39] scripts/checkpatch.pl: emit error when using assert(false)

Posted by Richard Henderson 2 months, 2 weeks ago

On 9/10/24 15:16, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   scripts/checkpatch.pl | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 65b6f46f905..fa9c12230eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3102,6 +3102,9 @@ sub process {
>   		if ($line =~ /\b(g_)?assert\(0\)/) {
>   			ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr);
>   		}
> +		if ($line =~ /\b(g_)?assert\(false\)/) {
> +			ERROR("use g_assert_not_reached() instead of assert(false)\n" . $herecurr);
> +		}
>   		if ($line =~ /\bstrerrorname_np\(/) {
>   			ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr);
>   		}

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~