[v1] Use g_assert_not_reached instead of (g_)assert(0, false)

[PATCH 30/39] hw/pci-host: remove break after g_assert_not_reached()

Posted by Pierrick Bouvier 2 months, 2 weeks ago

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 hw/pci-host/gt64120.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/pci-host/gt64120.c b/hw/pci-host/gt64120.c
index 33607dfbec4..58557416629 100644
--- a/hw/pci-host/gt64120.c
+++ b/hw/pci-host/gt64120.c
@@ -689,7 +689,6 @@ static void gt64120_writel(void *opaque, hwaddr addr,
     case GT_PCI0_CFGDATA:
         /* Mapped via in gt64120_pci_mapping() */
         g_assert_not_reached();
-        break;
 
     /* Interrupts */
     case GT_INTRCAUSE:
@@ -933,7 +932,6 @@ static uint64_t gt64120_readl(void *opaque,
     case GT_PCI0_CFGDATA:
         /* Mapped via in gt64120_pci_mapping() */
         g_assert_not_reached();
-        break;
 
     case GT_PCI0_CMD:
     case GT_PCI0_TOR:
-- 
2.39.2

Re: [PATCH 30/39] hw/pci-host: remove break after g_assert_not_reached()

Posted by Philippe Mathieu-Daudé 2 months, 2 weeks ago

On 11/9/24 00:15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/pci-host/gt64120.c | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 30/39] hw/pci-host: remove break after g_assert_not_reached()

Posted by Richard Henderson 2 months, 2 weeks ago

On 9/10/24 15:15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/pci-host/gt64120.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/hw/pci-host/gt64120.c b/hw/pci-host/gt64120.c
> index 33607dfbec4..58557416629 100644
> --- a/hw/pci-host/gt64120.c
> +++ b/hw/pci-host/gt64120.c
> @@ -689,7 +689,6 @@ static void gt64120_writel(void *opaque, hwaddr addr,
>       case GT_PCI0_CFGDATA:
>           /* Mapped via in gt64120_pci_mapping() */
>           g_assert_not_reached();
> -        break;
>   
>       /* Interrupts */
>       case GT_INTRCAUSE:
> @@ -933,7 +932,6 @@ static uint64_t gt64120_readl(void *opaque,
>       case GT_PCI0_CFGDATA:
>           /* Mapped via in gt64120_pci_mapping() */
>           g_assert_not_reached();
> -        break;
>   
>       case GT_PCI0_CMD:
>       case GT_PCI0_TOR:

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~