[v1] Use g_assert_not_reached instead of (g_)assert(0, false)

[PATCH 26/39] hw/acpi: remove break after g_assert_not_reached()

Posted by Pierrick Bouvier 2 months, 2 weeks ago

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 hw/acpi/aml-build.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 006c506a375..34e0ddbde87 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -535,7 +535,6 @@ void aml_append(Aml *parent_ctx, Aml *child)
         break;
     default:
         g_assert_not_reached();
-        break;
     }
     build_append_array(parent_ctx->buf, buf);
     build_free_array(buf);
-- 
2.39.2

Re: [PATCH 26/39] hw/acpi: remove break after g_assert_not_reached()

Posted by Richard Henderson 2 months, 2 weeks ago

On 9/10/24 15:15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   hw/acpi/aml-build.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 006c506a375..34e0ddbde87 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -535,7 +535,6 @@ void aml_append(Aml *parent_ctx, Aml *child)
>           break;
>       default:
>           g_assert_not_reached();
> -        break;
>       }
>       build_append_array(parent_ctx->buf, buf);
>       build_free_array(buf);

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~