[v1] Use g_assert_not_reached instead of (g_)assert(0, false)

[PATCH 14/39] include/hw/s390x: replace assert(false) with g_assert_not_reached()

Posted by Pierrick Bouvier 2 months, 2 weeks ago

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 include/hw/s390x/cpu-topology.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h
index c064f427e94..dcb25956a64 100644
--- a/include/hw/s390x/cpu-topology.h
+++ b/include/hw/s390x/cpu-topology.h
@@ -57,7 +57,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms,
 static inline void s390_topology_reset(void)
 {
     /* Unreachable, CPU topology not implemented for TCG */
-    assert(false);
+    g_assert_not_reached();
 }
 #endif
 
-- 
2.39.2

Re: [PATCH 14/39] include/hw/s390x: replace assert(false) with g_assert_not_reached()

Posted by Thomas Huth 2 months, 2 weeks ago

On 11/09/2024 00.15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   include/hw/s390x/cpu-topology.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h
> index c064f427e94..dcb25956a64 100644
> --- a/include/hw/s390x/cpu-topology.h
> +++ b/include/hw/s390x/cpu-topology.h
> @@ -57,7 +57,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms,
>   static inline void s390_topology_reset(void)
>   {
>       /* Unreachable, CPU topology not implemented for TCG */
> -    assert(false);
> +    g_assert_not_reached();
>   }
>   #endif
>   

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 14/39] include/hw/s390x: replace assert(false) with g_assert_not_reached()

Posted by Richard Henderson 2 months, 2 weeks ago

On 9/10/24 15:15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   include/hw/s390x/cpu-topology.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h
> index c064f427e94..dcb25956a64 100644
> --- a/include/hw/s390x/cpu-topology.h
> +++ b/include/hw/s390x/cpu-topology.h
> @@ -57,7 +57,7 @@ static inline void s390_topology_setup_cpu(MachineState *ms,
>   static inline void s390_topology_reset(void)
>   {
>       /* Unreachable, CPU topology not implemented for TCG */
> -    assert(false);
> +    g_assert_not_reached();
>   }
>   #endif
>   

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~