minikconf: print error entirely on stderr

[PATCH] minikconf: print error entirely on stderr

Posted by Paolo Bonzini 2 months, 2 weeks ago

While debugging an invalid configuration, I noticed that the clauses debug
ends up on stderr but the header ("The following clauses were found..."
ends up on stdout.  This makes the contents of meson-logs/meson-log.txt
a bit confusing.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/minikconf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/minikconf.py b/scripts/minikconf.py
index bcd91015d34..6f7f43b2918 100644
--- a/scripts/minikconf.py
+++ b/scripts/minikconf.py
@@ -112,7 +112,7 @@ def has_value(self):
         def set_value(self, val, clause):
             self.clauses_for_var.append(clause)
             if self.has_value() and self.value != val:
-                print("The following clauses were found for " + self.name)
+                print("The following clauses were found for " + self.name, file=sys.stderr)
                 for i in self.clauses_for_var:
                     print("    " + str(i), file=sys.stderr)
                 raise KconfigDataError('contradiction between clauses when setting %s' % self)
-- 
2.46.0

Re: [PATCH] minikconf: print error entirely on stderr

Posted by Philippe Mathieu-Daudé 2 months, 2 weeks ago

On 6/9/24 09:33, Paolo Bonzini wrote:
> While debugging an invalid configuration, I noticed that the clauses debug
> ends up on stderr but the header ("The following clauses were found..."
> ends up on stdout.  This makes the contents of meson-logs/meson-log.txt
> a bit confusing.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   scripts/minikconf.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>