hw/loongarch: Remove default enable with VIRTIO_VGA device

[PATCH] hw/loongarch: Remove default enable with VIRTIO_VGA device

Bibo Mao posted 1 patch 1 year, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240823073050.2619484-1-maobibo@loongson.cn

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Song Gao <gaosong@loongson.cn>, Bibo Mao <maobibo@loongson.cn>, Jiaxun Yang <jiaxun.yang@flygoat.com>

hw/loongarch/Kconfig | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] hw/loongarch: Remove default enable with VIRTIO_VGA device

Posted by Bibo Mao 1 year, 5 months ago

For virtio VGA deivce libvirt will select VIRTIO_VGA firstly rather than
VIRTIO_GPU, VIRTIO_VGA device supports frame buffer however it requires
legacy VGA compatible support. Frame buffer area 0xa0000 -- 0xc0000
conflicts with low memory area 0 -- 0x10000000.

Here remove default support for VIRTIO_VGA device, VIRTIO_GPU is prefered
on LoongArch system. For frame buffer video card support, standard VGA can
be used.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
 hw/loongarch/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig
index 0de713a439..9c69170968 100644
--- a/hw/loongarch/Kconfig
+++ b/hw/loongarch/Kconfig
@@ -5,7 +5,6 @@ config LOONGARCH_VIRT
     select DEVICE_TREE
     select PCI
     select PCI_EXPRESS_GENERIC_BRIDGE
-    imply VIRTIO_VGA
     imply PCI_DEVICES
     imply NVDIMM
     imply TPM_TIS_SYSBUS

base-commit: 407f9a4b121eb65166375c410e14d7b704bc1106
-- 
2.39.3

Re: [PATCH] hw/loongarch: Remove default enable with VIRTIO_VGA device

Posted by gaosong 1 year, 5 months ago


在 2024/8/23 下午3:30, Bibo Mao 写道:
> For virtio VGA deivce libvirt will select VIRTIO_VGA firstly rather than
> VIRTIO_GPU, VIRTIO_VGA device supports frame buffer however it requires
> legacy VGA compatible support. Frame buffer area 0xa0000 -- 0xc0000
> conflicts with low memory area 0 -- 0x10000000.
> 
> Here remove default support for VIRTIO_VGA device, VIRTIO_GPU is prefered
> on LoongArch system. For frame buffer video card support, standard VGA can
> be used.
> 
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>   hw/loongarch/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
Reviewed-by: Song Gao <gaosong@loongson.cn>

Thanks
Song Gao
> diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig
> index 0de713a439..9c69170968 100644
> --- a/hw/loongarch/Kconfig
> +++ b/hw/loongarch/Kconfig
> @@ -5,7 +5,6 @@ config LOONGARCH_VIRT
>       select DEVICE_TREE
>       select PCI
>       select PCI_EXPRESS_GENERIC_BRIDGE
> -    imply VIRTIO_VGA
>       imply PCI_DEVICES
>       imply NVDIMM
>       imply TPM_TIS_SYSBUS
> 
> base-commit: 407f9a4b121eb65166375c410e14d7b704bc1106
>