[v4] Fix check-qtest-ppc64 sanitizer errors

[PATCH v4 1/7] migration: Free removed SaveStateEntry

Posted by Akihiko Odaki 3 months ago

This fixes LeakSanitizer warnings.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---
 migration/savevm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/migration/savevm.c b/migration/savevm.c
index deb57833f8a8..85958d7b09cd 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -874,6 +874,8 @@ int vmstate_replace_hack_for_ppc(VMStateIf *obj, int instance_id,
 
     if (se) {
         savevm_state_handler_remove(se);
+        g_free(se->compat);
+        g_free(se);
     }
     return vmstate_register(obj, instance_id, vmsd, opaque);
 }

-- 
2.46.0

Re: [PATCH v4 1/7] migration: Free removed SaveStateEntry

Posted by Fabiano Rosas 3 months ago

Akihiko Odaki <akihiko.odaki@daynix.com> writes:

> This fixes LeakSanitizer warnings.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  migration/savevm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index deb57833f8a8..85958d7b09cd 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -874,6 +874,8 @@ int vmstate_replace_hack_for_ppc(VMStateIf *obj, int instance_id,
>  
>      if (se) {
>          savevm_state_handler_remove(se);
> +        g_free(se->compat);
> +        g_free(se);
>      }
>      return vmstate_register(obj, instance_id, vmsd, opaque);
>  }

This one was merged already.