[v1] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup

[PATCH for-9.2 05/10] hw/dma/xilinx_axidma: Use semicolon at end of statement, not comma

Posted by Peter Maydell 3 months, 1 week ago

In axidma_class_init() we accidentally used a comma at the end of
a statement rather than a semicolon. This has no ill effects, but
it's obviously not intended and it means that Coccinelle scripts
for instance will fail to match on the two statements. Use a
semicolon instead.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/dma/xilinx_axidma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
index c9cfc3169b8..7707634253a 100644
--- a/hw/dma/xilinx_axidma.c
+++ b/hw/dma/xilinx_axidma.c
@@ -626,7 +626,7 @@ static void axidma_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
 
-    dc->realize = xilinx_axidma_realize,
+    dc->realize = xilinx_axidma_realize;
     dc->reset = xilinx_axidma_reset;
     device_class_set_props(dc, axidma_properties);
 }
-- 
2.34.1

Re: [PATCH for-9.2 05/10] hw/dma/xilinx_axidma: Use semicolon at end of statement, not comma

Posted by Thomas Huth 3 months, 1 week ago

On 13/08/2024 18.52, Peter Maydell wrote:
> In axidma_class_init() we accidentally used a comma at the end of
> a statement rather than a semicolon. This has no ill effects, but
> it's obviously not intended and it means that Coccinelle scripts
> for instance will fail to match on the two statements. Use a
> semicolon instead.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   hw/dma/xilinx_axidma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
> index c9cfc3169b8..7707634253a 100644
> --- a/hw/dma/xilinx_axidma.c
> +++ b/hw/dma/xilinx_axidma.c
> @@ -626,7 +626,7 @@ static void axidma_class_init(ObjectClass *klass, void *data)
>   {
>       DeviceClass *dc = DEVICE_CLASS(klass);
>   
> -    dc->realize = xilinx_axidma_realize,
> +    dc->realize = xilinx_axidma_realize;
>       dc->reset = xilinx_axidma_reset;
>       device_class_set_props(dc, axidma_properties);
>   }

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH for-9.2 05/10] hw/dma/xilinx_axidma: Use semicolon at end of statement, not comma

Posted by Richard Henderson 3 months, 1 week ago

On 8/14/24 02:52, Peter Maydell wrote:
> In axidma_class_init() we accidentally used a comma at the end of
> a statement rather than a semicolon. This has no ill effects, but
> it's obviously not intended and it means that Coccinelle scripts
> for instance will fail to match on the two statements. Use a
> semicolon instead.
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   hw/dma/xilinx_axidma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~