meson: Rationalize sanitizer configuration

[PATCH for-9.2? 0/2] meson: Rationalize sanitizer configuration

Posted by Richard Henderson 3 months, 1 week ago

In the CI that we actually run (x86) we don't want to use ASan,
only UBSan, we jump through --extra-cflags hoops to make that
happen, and we fail to disable function sanitizer during normal
configuration.

In the CI that we don't run, we enable ASan and fail to disable
function sanitizer.  So its a bit lucky that don't run it.

Split the --enable-santizers config option, and move stuff back
to meson.build from .gitlab-ci.d.


r~


Richard Henderson (2):
  meson: Split --enable-sanitizers to --enable-{asan,ubsan}
  meson: Move -fsanitize=undefined into normal configuraton

 tests/qtest/fdc-test.c                        |  2 +-
 .gitlab-ci.d/buildtest.yml                    | 10 +++----
 .../custom-runners/ubuntu-22.04-aarch64.yml   |  2 +-
 .../custom-runners/ubuntu-22.04-s390x.yml     |  2 +-
 docs/devel/fuzzing.rst                        |  4 +--
 meson.build                                   | 26 ++++++++++++++-----
 meson_options.txt                             |  6 +++--
 scripts/meson-buildoptions.sh                 |  9 ++++---
 tests/docker/test-debug                       |  4 +--
 9 files changed, 41 insertions(+), 24 deletions(-)

-- 
2.43.0

Re: [PATCH for-9.2? 0/2] meson: Rationalize sanitizer configuration

Posted by Thomas Huth 2 months, 2 weeks ago

On 13/08/2024 11.52, Richard Henderson wrote:
> In the CI that we actually run (x86) we don't want to use ASan,
> only UBSan, we jump through --extra-cflags hoops to make that
> happen, and we fail to disable function sanitizer during normal
> configuration.
> 
> In the CI that we don't run, we enable ASan and fail to disable
> function sanitizer.  So its a bit lucky that don't run it.
> 
> Split the --enable-santizers config option, and move stuff back
> to meson.build from .gitlab-ci.d.


Reviewed-by: Thomas Huth <thuth@redhat.com>
and queued.

Re: [PATCH for-9.2? 0/2] meson: Rationalize sanitizer configuration

Posted by Richard Henderson 2 months, 2 weeks ago

Ping.

On 8/13/24 02:52, Richard Henderson wrote:
> In the CI that we actually run (x86) we don't want to use ASan,
> only UBSan, we jump through --extra-cflags hoops to make that
> happen, and we fail to disable function sanitizer during normal
> configuration.
> 
> In the CI that we don't run, we enable ASan and fail to disable
> function sanitizer.  So its a bit lucky that don't run it.
> 
> Split the --enable-santizers config option, and move stuff back
> to meson.build from .gitlab-ci.d.
> 
> 
> r~
> 
> 
> Richard Henderson (2):
>    meson: Split --enable-sanitizers to --enable-{asan,ubsan}
>    meson: Move -fsanitize=undefined into normal configuraton
> 
>   tests/qtest/fdc-test.c                        |  2 +-
>   .gitlab-ci.d/buildtest.yml                    | 10 +++----
>   .../custom-runners/ubuntu-22.04-aarch64.yml   |  2 +-
>   .../custom-runners/ubuntu-22.04-s390x.yml     |  2 +-
>   docs/devel/fuzzing.rst                        |  4 +--
>   meson.build                                   | 26 ++++++++++++++-----
>   meson_options.txt                             |  6 +++--
>   scripts/meson-buildoptions.sh                 |  9 ++++---
>   tests/docker/test-debug                       |  4 +--
>   9 files changed, 41 insertions(+), 24 deletions(-)
>