ppc: fix incorrect spelling of PowerMac

[PATCH] ppc: fix incorrect spelling of PowerMac

Posted by Tejas Vipin 3 months, 3 weeks ago

PowerMac is spelled as PowerMAC (Media Access Control) in some places.
This is misleading.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2297
Signed-off-by: Tejas Vipin <tejasvipin76@gmail.com>
---
 docs/system/ppc/powermac.rst | 4 ++--
 hw/ppc/mac_newworld.c        | 2 +-
 hw/ppc/mac_oldworld.c        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/system/ppc/powermac.rst b/docs/system/ppc/powermac.rst
index 04334ba210..3eac81c491 100644
--- a/docs/system/ppc/powermac.rst
+++ b/docs/system/ppc/powermac.rst
@@ -4,8 +4,8 @@ PowerMac family boards (``g3beige``, ``mac99``)
 Use the executable ``qemu-system-ppc`` to simulate a complete PowerMac
 PowerPC system.
 
-- ``g3beige``              Heathrow based PowerMAC
-- ``mac99``                Mac99 based PowerMAC
+- ``g3beige``              Heathrow based PowerMac
+- ``mac99``                Mac99 based PowerMac
 
 Supported devices
 -----------------
diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index ff9e490c4e..9d249a506c 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -571,7 +571,7 @@ static void core99_machine_class_init(ObjectClass *oc, void *data)
     MachineClass *mc = MACHINE_CLASS(oc);
     FWPathProviderClass *fwc = FW_PATH_PROVIDER_CLASS(oc);
 
-    mc->desc = "Mac99 based PowerMAC";
+    mc->desc = "Mac99 based PowerMac";
     mc->init = ppc_core99_init;
     mc->block_default_type = IF_IDE;
     /* SMP is not supported currently */
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
index 1981d3d8f6..eef3261002 100644
--- a/hw/ppc/mac_oldworld.c
+++ b/hw/ppc/mac_oldworld.c
@@ -411,7 +411,7 @@ static void heathrow_class_init(ObjectClass *oc, void *data)
     MachineClass *mc = MACHINE_CLASS(oc);
     FWPathProviderClass *fwc = FW_PATH_PROVIDER_CLASS(oc);
 
-    mc->desc = "Heathrow based PowerMAC";
+    mc->desc = "Heathrow based PowerMac";
     mc->init = ppc_heathrow_init;
     mc->block_default_type = IF_IDE;
     /* SMP is not supported currently */
-- 
2.46.0

Re: [PATCH] ppc: fix incorrect spelling of PowerMac

Posted by Michael Tokarev 2 months, 2 weeks ago

05.08.2024 10:01, Tejas Vipin wrote:
> PowerMac is spelled as PowerMAC (Media Access Control) in some places.
> This is misleading.

Applied to my trivial-patches tree, thanks!

/mjt

Re: [PATCH] ppc: fix incorrect spelling of PowerMac

Posted by Philippe Mathieu-Daudé 3 months, 3 weeks ago

Hi Tejas,

On 5/8/24 09:01, Tejas Vipin wrote:
> PowerMac is spelled as PowerMAC (Media Access Control) in some places.
> This is misleading.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2297
> Signed-off-by: Tejas Vipin <tejasvipin76@gmail.com>
> ---
>   docs/system/ppc/powermac.rst | 4 ++--
>   hw/ppc/mac_newworld.c        | 2 +-
>   hw/ppc/mac_oldworld.c        | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/system/ppc/powermac.rst b/docs/system/ppc/powermac.rst
> index 04334ba210..3eac81c491 100644
> --- a/docs/system/ppc/powermac.rst
> +++ b/docs/system/ppc/powermac.rst
> @@ -4,8 +4,8 @@ PowerMac family boards (``g3beige``, ``mac99``)
>   Use the executable ``qemu-system-ppc`` to simulate a complete PowerMac
>   PowerPC system.
>   
> -- ``g3beige``              Heathrow based PowerMAC
> -- ``mac99``                Mac99 based PowerMAC
> +- ``g3beige``              Heathrow based PowerMac
> +- ``mac99``                Mac99 based PowerMac
>   
>   Supported devices
>   -----------------
> diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
> index ff9e490c4e..9d249a506c 100644
> --- a/hw/ppc/mac_newworld.c
> +++ b/hw/ppc/mac_newworld.c
> @@ -571,7 +571,7 @@ static void core99_machine_class_init(ObjectClass *oc, void *data)
>       MachineClass *mc = MACHINE_CLASS(oc);
>       FWPathProviderClass *fwc = FW_PATH_PROVIDER_CLASS(oc);
>   
> -    mc->desc = "Mac99 based PowerMAC";
> +    mc->desc = "Mac99 based PowerMac";
>       mc->init = ppc_core99_init;
>       mc->block_default_type = IF_IDE;
>       /* SMP is not supported currently */
> diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
> index 1981d3d8f6..eef3261002 100644
> --- a/hw/ppc/mac_oldworld.c
> +++ b/hw/ppc/mac_oldworld.c
> @@ -411,7 +411,7 @@ static void heathrow_class_init(ObjectClass *oc, void *data)
>       MachineClass *mc = MACHINE_CLASS(oc);
>       FWPathProviderClass *fwc = FW_PATH_PROVIDER_CLASS(oc);
>   
> -    mc->desc = "Heathrow based PowerMAC";
> +    mc->desc = "Heathrow based PowerMac";

It seems it is even spelt with a space as "Power Mac".
Anyhow this is still better than MAC, so:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>