tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

[RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

Posted by Philippe Mathieu-Daudé 3 months, 3 weeks ago

We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
rationalise unstable gitlab tests under FLAKY_TESTS") for
being flaky. However I don't recall the U-Boot test to fail
(the problematic line checking the 'version' string is already
commented out), and I'm running this test reliably, so re-enable
it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/avocado/machine_rx_gdbsim.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/avocado/machine_rx_gdbsim.py b/tests/avocado/machine_rx_gdbsim.py
index 412a7a5089..a83873b738 100644
--- a/tests/avocado/machine_rx_gdbsim.py
+++ b/tests/avocado/machine_rx_gdbsim.py
@@ -22,8 +22,6 @@ class RxGdbSimMachine(QemuSystemTest):
     timeout = 30
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
 
-    @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
-
     def test_uboot(self):
         """
         U-Boot and checks that the console is operational.
-- 
2.45.2

Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

Posted by Alex Bennée 3 months, 2 weeks ago

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
> rationalise unstable gitlab tests under FLAKY_TESTS") for
> being flaky. However I don't recall the U-Boot test to fail
> (the problematic line checking the 'version' string is already
> commented out), and I'm running this test reliably, so re-enable
> it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Queued to for-9.1/misc-fixes, thanks.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

Posted by Yoshinori Sato 3 months, 3 weeks ago

On Fri, 02 Aug 2024 02:23:32 +0900,
Philippe Mathieu-Daudé wrote:
> 
> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
> rationalise unstable gitlab tests under FLAKY_TESTS") for
> being flaky. However I don't recall the U-Boot test to fail
> (the problematic line checking the 'version' string is already
> commented out), and I'm running this test reliably, so re-enable
> it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  tests/avocado/machine_rx_gdbsim.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tests/avocado/machine_rx_gdbsim.py b/tests/avocado/machine_rx_gdbsim.py
> index 412a7a5089..a83873b738 100644
> --- a/tests/avocado/machine_rx_gdbsim.py
> +++ b/tests/avocado/machine_rx_gdbsim.py
> @@ -22,8 +22,6 @@ class RxGdbSimMachine(QemuSystemTest):
>      timeout = 30
>      KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
>  
> -    @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
> -
>      def test_uboot(self):
>          """
>          U-Boot and checks that the console is operational.
> -- 
> 2.45.2
> 

Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

-- 
Yosinori Sato

Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

Posted by Philippe Mathieu-Daudé 3 months, 2 weeks ago

On 5/8/24 08:54, Yoshinori Sato wrote:
> On Fri, 02 Aug 2024 02:23:32 +0900,
> Philippe Mathieu-Daudé wrote:
>>
>> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
>> rationalise unstable gitlab tests under FLAKY_TESTS") for
>> being flaky. However I don't recall the U-Boot test to fail
>> (the problematic line checking the 'version' string is already
>> commented out), and I'm running this test reliably, so re-enable
>> it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   tests/avocado/machine_rx_gdbsim.py | 2 --
>>   1 file changed, 2 deletions(-)

> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

Thanks, I'll queue this patch for 9.2 to avoid messing
with the next release.

Regards,

Phil.

Re: [RFC PATCH] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot

Posted by Alex Bennée 3 months, 2 weeks ago

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 5/8/24 08:54, Yoshinori Sato wrote:
>> On Fri, 02 Aug 2024 02:23:32 +0900,
>> Philippe Mathieu-Daudé wrote:
>>>
>>> We disabled all RX tests on commit 9b45cc9931 ("docs/devel:
>>> rationalise unstable gitlab tests under FLAKY_TESTS") for
>>> being flaky. However I don't recall the U-Boot test to fail
>>> (the problematic line checking the 'version' string is already
>>> commented out), and I'm running this test reliably, so re-enable
>>> it.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>>   tests/avocado/machine_rx_gdbsim.py | 2 --
>>>   1 file changed, 2 deletions(-)
>
>> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
> Thanks, I'll queue this patch for 9.2 to avoid messing
> with the next release.

Testing updates are usually fine, but I can leave it to you to merge if
you prefer.

>
> Regards,
>
> Phil.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro