guest-agent: document allow-rpcs in config file section

[PATCH] guest-agent: document allow-rpcs in config file section

Thomas Lamprecht posted 1 patch 1 month, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240718140407.444160-1-t.lamprecht@proxmox.com

Maintainers: Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>

docs/interop/qemu-ga.rst | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] guest-agent: document allow-rpcs in config file section

Posted by Thomas Lamprecht 1 month, 3 weeks ago

While the `allow-rpcs` option is documented in the CLI options
section, it was missing in the section about the configuration file
syntax.

And while it's mentioned that "the list of keys follows the command line
options", having `block-rpcs` there but not `allow-rpcs` seems like
being a potential source of confusion; and as it's cheap to add let's
just do so.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 docs/interop/qemu-ga.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
index 72fb75a6f5..dd4245ece8 100644
--- a/docs/interop/qemu-ga.rst
+++ b/docs/interop/qemu-ga.rst
@@ -131,6 +131,7 @@ fsfreeze-hook  string
 statedir       string
 verbose        boolean
 block-rpcs     string list
+allow-rpcs     string list
 =============  ===========
 
 See also
-- 
2.39.2

Re: [PATCH] guest-agent: document allow-rpcs in config file section

Posted by Konstantin Kostiuk 1 month, 2 weeks ago

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Thu, Jul 18, 2024 at 5:05 PM Thomas Lamprecht <t.lamprecht@proxmox.com>
wrote:

> While the `allow-rpcs` option is documented in the CLI options
> section, it was missing in the section about the configuration file
> syntax.
>
> And while it's mentioned that "the list of keys follows the command line
> options", having `block-rpcs` there but not `allow-rpcs` seems like
> being a potential source of confusion; and as it's cheap to add let's
> just do so.
>
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> ---
>  docs/interop/qemu-ga.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
> index 72fb75a6f5..dd4245ece8 100644
> --- a/docs/interop/qemu-ga.rst
> +++ b/docs/interop/qemu-ga.rst
> @@ -131,6 +131,7 @@ fsfreeze-hook  string
>  statedir       string
>  verbose        boolean
>  block-rpcs     string list
> +allow-rpcs     string list
>  =============  ===========
>
>  See also
> --
> 2.39.2
>
>
>
>