1. Patchew
  2. QEMU
  3. View series

[PATCH v3 0/9] XIVE changes for Cache Watch, VSTs, STT and info pic

Michael Kowal posted 9 patches 1 month, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20240716195633.12679-1-kowal@linux.vnet.ibm.com
Maintainers: "Cédric Le Goater" <clg@kaod.org>, Nicholas Piggin <npiggin@gmail.com>, "Frédéric Barrat" <fbarrat@linux.ibm.com>
There is a newer version of this series
hw/intc/pnv_xive2_regs.h    | 108 +++++++
include/hw/ppc/pnv_chip.h   |   1 +
include/hw/ppc/xive2_regs.h |   9 +
hw/intc/pnv_xive2.c         | 566 ++++++++++++++++++++++++++++++------
hw/intc/xive.c              |  12 +-
hw/intc/xive2.c             |  33 ++-
6 files changed, 633 insertions(+), 96 deletions(-)
[PATCH v3 0/9] XIVE changes for Cache Watch, VSTs, STT and info pic
Posted by Michael Kowal 1 month, 3 weeks ago 
These changes provide enhanced support of the External Interrupt Virtualization
Engine.  The changes are focused on the following areas:
 - Cache Watch, Cache Flush and Sync Injection
 - Virtual Structure Tables
 - Set Translation Table
 - 'info pic' command data that is dumped

Frederic Barrat (7):
  pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support
  pnv/xive2: Add NVG and NVC to cache watch facility
  pnv/xive2: Configure Virtualization Structure Tables through the PC
  pnv/xive2: Enable VST NVG and NVC index compression
  pnv/xive2: Set Translation Table for the NVC port space
  pnv/xive2: Fail VST entry address computation if table has no VSD
  pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c

Michael Kowal (1):
  pnv/xive2: Structure/define alignment changes

Nicholas Piggin (1):
  pnv/xive: Support cache flush and queue sync inject with notifications

 hw/intc/pnv_xive2_regs.h    | 108 +++++++
 include/hw/ppc/pnv_chip.h   |   1 +
 include/hw/ppc/xive2_regs.h |   9 +
 hw/intc/pnv_xive2.c         | 566 ++++++++++++++++++++++++++++++------
 hw/intc/xive.c              |  12 +-
 hw/intc/xive2.c             |  33 ++-
 6 files changed, 633 insertions(+), 96 deletions(-)

--
2.43.0
Re: [PATCH v3 0/9] XIVE changes for Cache Watch, VSTs, STT and info pic
Posted by Cédric Le Goater 1 month, 3 weeks ago 
Hello Mike,

On 7/16/24 21:56, Michael Kowal wrote:
> These changes provide enhanced support of the External Interrupt Virtualization
> Engine.  The changes are focused on the following areas:
>   - Cache Watch, Cache Flush and Sync Injection
>   - Virtual Structure Tables
>   - Set Translation Table
>   - 'info pic' command data that is dumped
> 
> Frederic Barrat (7):
>    pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support
>    pnv/xive2: Add NVG and NVC to cache watch facility
>    pnv/xive2: Configure Virtualization Structure Tables through the PC
>    pnv/xive2: Enable VST NVG and NVC index compression
>    pnv/xive2: Set Translation Table for the NVC port space
>    pnv/xive2: Fail VST entry address computation if table has no VSD
>    pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c
> 
> Michael Kowal (1):
>    pnv/xive2: Structure/define alignment changes
> 
> Nicholas Piggin (1):
>    pnv/xive: Support cache flush and queue sync inject with notifications
> 
>   hw/intc/pnv_xive2_regs.h    | 108 +++++++
>   include/hw/ppc/pnv_chip.h   |   1 +
>   include/hw/ppc/xive2_regs.h |   9 +
>   hw/intc/pnv_xive2.c         | 566 ++++++++++++++++++++++++++++++------
>   hw/intc/xive.c              |  12 +-
>   hw/intc/xive2.c             |  33 ++-
>   6 files changed, 633 insertions(+), 96 deletions(-)
> 
> --
> 2.43.0
> 

Hello Mike,

When you respin a series, it is useful to update the individual
patches with the given R-b tags. To keep track of them, you can use
the b4 command :
   
   $ b4 am 20240715183332.27287-1-kowal@linux.vnet.ibm.com
   Grabbing thread from lore.kernel.org/all/20240715183332.27287-1-kowal@linux.vnet.ibm.com/t.mbox.gz
   Analyzing 23 messages in the thread
   Looking for additional code-review trailers on lore.kernel.org
   Checking attestation on all messages, may take a moment...
   ---
     ✓ [PATCH v2 1/9] pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support
     ✓ [PATCH v2 2/9] pnv/xive2: Structure/define alignment changes
       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
     ✓ [PATCH v2 3/9] pnv/xive: Support cache flush and queue sync inject with notifications
     ✓ [PATCH v2 4/9] pnv/xive2: Add NVG and NVC to cache watch facility
     ✓ [PATCH v2 5/9] pnv/xive2: Configure Virtualization Structure Tables through the PC
       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
     ✓ [PATCH v2 6/9] pnv/xive2: Enable VST NVG and NVC index compression
       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
     ✓ [PATCH v2 7/9] pnv/xive2: Set Translation Table for the NVC port space
       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
       + Reviewed-by: Cédric Le Goater <clg@kaod.org>
     ✓ [PATCH v2 8/9] pnv/xive2: Fail VST entry address computation if table has no VSD
       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
       + Reviewed-by: Cédric Le Goater <clg@kaod.org>
     ✓ [PATCH v2 9/9] pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c
     ---
     ✓ Signed: DKIM/ibm.com (From: kowal@linux.vnet.ibm.com)
   


Thanks,

C.
Re: [PATCH v3 0/9] XIVE changes for Cache Watch, VSTs, STT and info pic
Posted by Mike Kowal 1 month, 3 weeks ago 
On 7/16/2024 3:18 PM, Cédric Le Goater wrote:
> Hello Mike,
>
> On 7/16/24 21:56, Michael Kowal wrote:
>> These changes provide enhanced support of the External Interrupt 
>> Virtualization
>> Engine.  The changes are focused on the following areas:
>>   - Cache Watch, Cache Flush and Sync Injection
>>   - Virtual Structure Tables
>>   - Set Translation Table
>>   - 'info pic' command data that is dumped
>>
>> Frederic Barrat (7):
>>    pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support
>>    pnv/xive2: Add NVG and NVC to cache watch facility
>>    pnv/xive2: Configure Virtualization Structure Tables through the PC
>>    pnv/xive2: Enable VST NVG and NVC index compression
>>    pnv/xive2: Set Translation Table for the NVC port space
>>    pnv/xive2: Fail VST entry address computation if table has no VSD
>>    pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c
>>
>> Michael Kowal (1):
>>    pnv/xive2: Structure/define alignment changes
>>
>> Nicholas Piggin (1):
>>    pnv/xive: Support cache flush and queue sync inject with 
>> notifications
>>
>>   hw/intc/pnv_xive2_regs.h    | 108 +++++++
>>   include/hw/ppc/pnv_chip.h   |   1 +
>>   include/hw/ppc/xive2_regs.h |   9 +
>>   hw/intc/pnv_xive2.c         | 566 ++++++++++++++++++++++++++++++------
>>   hw/intc/xive.c              |  12 +-
>>   hw/intc/xive2.c             |  33 ++-
>>   6 files changed, 633 insertions(+), 96 deletions(-)
>>
>> -- 
>> 2.43.0
>>
>
> Hello Mike,
>
> When you respin a series, it is useful to update the individual
> patches with the given R-b tags. To keep track of them, you can use
> the b4 command :
>     $ b4 am 20240715183332.27287-1-kowal@linux.vnet.ibm.com
>   Grabbing thread from 
> lore.kernel.org/all/20240715183332.27287-1-kowal@linux.vnet.ibm.com/t.mbox.gz
>   Analyzing 23 messages in the thread
>   Looking for additional code-review trailers on lore.kernel.org
>   Checking attestation on all messages, may take a moment...
>   ---
>     ✓ [PATCH v2 1/9] pnv/xive2: XIVE2 Cache Watch, Cache Flush and 
> Sync Injection support
>     ✓ [PATCH v2 2/9] pnv/xive2: Structure/define alignment changes
>       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
>     ✓ [PATCH v2 3/9] pnv/xive: Support cache flush and queue sync 
> inject with notifications
>     ✓ [PATCH v2 4/9] pnv/xive2: Add NVG and NVC to cache watch facility
>     ✓ [PATCH v2 5/9] pnv/xive2: Configure Virtualization Structure 
> Tables through the PC
>       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
>     ✓ [PATCH v2 6/9] pnv/xive2: Enable VST NVG and NVC index compression
>       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
>     ✓ [PATCH v2 7/9] pnv/xive2: Set Translation Table for the NVC port 
> space
>       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
>       + Reviewed-by: Cédric Le Goater <clg@kaod.org>
>     ✓ [PATCH v2 8/9] pnv/xive2: Fail VST entry address computation if 
> table has no VSD
>       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
>       + Reviewed-by: Cédric Le Goater <clg@kaod.org>
>     ✓ [PATCH v2 9/9] pnv/xive2: Move xive2_nvp_pic_print_info() to 
> xive2.c
>     ---
>     ✓ Signed: DKIM/ibm.com (From: kowal@linux.vnet.ibm.com)
>
Thank you for the suggestion Cedric.  I can get `b4 am` to run but the 
attestation (signature checking?) fails.  In the future I will post the 
following, along with revision comments in the cover letter.  Following 
is the output for v3:

   [PATCH v3 1/9] pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync 
Injection support
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
   [PATCH v3 2/9] pnv/xive2: Structure/define alignment changes
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
   [PATCH v3 3/9] pnv/xive: Support cache flush and queue sync inject 
with notifications
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
   [PATCH v3 4/9] pnv/xive2: Add NVG and NVC to cache watch facility
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
   [PATCH v3 5/9] pnv/xive2: Configure Virtualization Structure Tables 
through the PC
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
   [PATCH v3 6/9] pnv/xive2: Enable VST NVG and NVC index compression
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
   [PATCH v3 7/9] pnv/xive2: Set Translation Table for the NVC port space
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
     + Reviewed-by: Cédric Le Goater <clg@kaod.org>
   [PATCH v3 8/9] pnv/xive2: Fail VST entry address computation if table 
has no VSD
     + Reviewed-by: Cédric Le Goater <clg@redhat.com>
     + Reviewed-by: Cédric Le Goater <clg@kaod.org>
   [PATCH v3 9/9] pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c
---
Total patches: 9

Thanks, Mike...


> Thanks,
>
> C.
>
>
Re: [PATCH v3 0/9] XIVE changes for Cache Watch, VSTs, STT and info pic
Posted by Nicholas Piggin 1 month, 2 weeks ago 
On Fri Jul 19, 2024 at 2:38 AM AEST, Mike Kowal wrote:
>
> On 7/16/2024 3:18 PM, Cédric Le Goater wrote:
> > Hello Mike,
> >
> > On 7/16/24 21:56, Michael Kowal wrote:
> >> These changes provide enhanced support of the External Interrupt 
> >> Virtualization
> >> Engine.  The changes are focused on the following areas:
> >>   - Cache Watch, Cache Flush and Sync Injection
> >>   - Virtual Structure Tables
> >>   - Set Translation Table
> >>   - 'info pic' command data that is dumped
> >>
> >> Frederic Barrat (7):
> >>    pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support
> >>    pnv/xive2: Add NVG and NVC to cache watch facility
> >>    pnv/xive2: Configure Virtualization Structure Tables through the PC
> >>    pnv/xive2: Enable VST NVG and NVC index compression
> >>    pnv/xive2: Set Translation Table for the NVC port space
> >>    pnv/xive2: Fail VST entry address computation if table has no VSD
> >>    pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c
> >>
> >> Michael Kowal (1):
> >>    pnv/xive2: Structure/define alignment changes
> >>
> >> Nicholas Piggin (1):
> >>    pnv/xive: Support cache flush and queue sync inject with 
> >> notifications
> >>
> >>   hw/intc/pnv_xive2_regs.h    | 108 +++++++
> >>   include/hw/ppc/pnv_chip.h   |   1 +
> >>   include/hw/ppc/xive2_regs.h |   9 +
> >>   hw/intc/pnv_xive2.c         | 566 ++++++++++++++++++++++++++++++------
> >>   hw/intc/xive.c              |  12 +-
> >>   hw/intc/xive2.c             |  33 ++-
> >>   6 files changed, 633 insertions(+), 96 deletions(-)
> >>
> >> -- 
> >> 2.43.0
> >>
> >
> > Hello Mike,
> >
> > When you respin a series, it is useful to update the individual
> > patches with the given R-b tags. To keep track of them, you can use
> > the b4 command :
> >     $ b4 am 20240715183332.27287-1-kowal@linux.vnet.ibm.com
> >   Grabbing thread from 
> > lore.kernel.org/all/20240715183332.27287-1-kowal@linux.vnet.ibm.com/t.mbox.gz
> >   Analyzing 23 messages in the thread
> >   Looking for additional code-review trailers on lore.kernel.org
> >   Checking attestation on all messages, may take a moment...
> >   ---
> >     ✓ [PATCH v2 1/9] pnv/xive2: XIVE2 Cache Watch, Cache Flush and 
> > Sync Injection support
> >     ✓ [PATCH v2 2/9] pnv/xive2: Structure/define alignment changes
> >       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
> >     ✓ [PATCH v2 3/9] pnv/xive: Support cache flush and queue sync 
> > inject with notifications
> >     ✓ [PATCH v2 4/9] pnv/xive2: Add NVG and NVC to cache watch facility
> >     ✓ [PATCH v2 5/9] pnv/xive2: Configure Virtualization Structure 
> > Tables through the PC
> >       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
> >     ✓ [PATCH v2 6/9] pnv/xive2: Enable VST NVG and NVC index compression
> >       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
> >     ✓ [PATCH v2 7/9] pnv/xive2: Set Translation Table for the NVC port 
> > space
> >       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
> >       + Reviewed-by: Cédric Le Goater <clg@kaod.org>
> >     ✓ [PATCH v2 8/9] pnv/xive2: Fail VST entry address computation if 
> > table has no VSD
> >       + Reviewed-by: Cédric Le Goater <clg@redhat.com>
> >       + Reviewed-by: Cédric Le Goater <clg@kaod.org>
> >     ✓ [PATCH v2 9/9] pnv/xive2: Move xive2_nvp_pic_print_info() to 
> > xive2.c
> >     ---
> >     ✓ Signed: DKIM/ibm.com (From: kowal@linux.vnet.ibm.com)
> >
> Thank you for the suggestion Cedric.  I can get `b4 am` to run but the 
> attestation (signature checking?) fails.  In the future I will post the 
> following, along with revision comments in the cover letter.  Following 

Hey Mike,

It's enough just that those 'Reviewed-by' lines are added to your
individual commit changelogs before you re-send. No need to send
the b4 output.

Thanks,
Nick

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.